Skip to content

feat: display battery applet when there is no battery#1370

Merged
wash2 merged 2 commits into
masterfrom
battery-applet-no-battery
Apr 3, 2026
Merged

feat: display battery applet when there is no battery#1370
wash2 merged 2 commits into
masterfrom
battery-applet-no-battery

Conversation

@wash2
Copy link
Copy Markdown
Contributor

@wash2 wash2 commented Apr 3, 2026

should fix #975 but probably shouldn't be merged until pop-os/iced#316 makes it in libcosmic.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@wash2 wash2 force-pushed the battery-applet-no-battery branch from 5d33614 to f20ef4e Compare April 3, 2026 02:36
@wash2 wash2 marked this pull request as ready for review April 3, 2026 15:06
@wash2 wash2 requested review from a team April 3, 2026 15:06
@jklgrasso jklgrasso self-assigned this Apr 3, 2026
Copy link
Copy Markdown

@jklgrasso jklgrasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like pop-os/iced#316 was merged, and the iced dependency was updated in pop-os/libcosmic#1217, which is also merged.

@wash2 wash2 merged commit b0f709a into master Apr 3, 2026
14 checks passed
@wash2 wash2 deleted the battery-applet-no-battery branch April 3, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Power applet is hidden when no battery is present, which is problematic for battery-less laptops

3 participants