Repository navigation
Commit 09e6e2d
authored
fix: stabilize OpenTelemetry exporter builder API (#2257)
Blocked by #2265 - to make
sure that breaking api change is correctly flagged
## Summary
- deprecate the `OpenTelemetryExporter(MetricReader)` constructor
instead of treating it as stable API
- make the builder entry points the stable surface for
`OpenTelemetryExporter`
- grandfather the already-accepted constructor removal in the API diff
workflow so unrelated PRs stop inheriting the failure on `main`
## Testing
- mise run lint:fix
- mise run build
- ./mvnw -B verify -pl
prometheus-metrics-exporter-opentelemetry,prometheus-metrics-exporter-opentelemetry-shaded
-am -P 'api-diff,!examples-and-integration-tests' -DskipTests
-Dcoverage.skip=true -Dcheckstyle.skip=true -Dwarnings=-nowarn1 parent 52124a3 commit 09e6e2d
3 files changed
Lines changed: 43 additions & 3 deletions
File tree
- docs/apidiffs/current_vs_latest
- prometheus-metrics-exporter-opentelemetry/src/main/java/io/prometheus/metrics/exporter/opentelemetry
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
15 | 19 | | |
16 | 20 | | |
17 | 21 | | |
18 | 22 | | |
| 23 | + | |
19 | 24 | | |
20 | 25 | | |
21 | 26 | | |
22 | 27 | | |
23 | 28 | | |
| 29 | + | |
24 | 30 | | |
25 | 31 | | |
26 | 32 | | |
27 | 33 | | |
| 34 | + | |
28 | 35 | | |
29 | 36 | | |
30 | 37 | | |
31 | 38 | | |
| 39 | + | |
32 | 40 | | |
33 | 41 | | |
34 | 42 | | |
| |||
0 commit comments