Skip to content

[FEA] Change cudf_polars testing assertion function to require an engine argument. #22346

@mroeschke

Description

@mroeschke

#22212 refactored the cudf_polars test suite to eventually parametrize over pytest fixtures of the engines we want to support (SPMD, Dask, Ray). We mostly pass this engine fixture to our assertion function in python/cudf_polars/cudf_polars/testing/asserts.py, but

  • assert_gpu_result_equal and assert_sink_result_equal provides the "default" if not specified

engine = engine or get_default_engine(executor)

engine = engine or get_default_engine(executor)

  • assert_ir_translation_raises, assert_collect_raises, and assert_sink_ir_translation_raises don't provide a way to override a hardcoded engine

translator = Translator(q._ldf.visit(), GPUEngine())

engine = GPUEngine(raise_on_fail=True)

therefore we are potentially not testing the pytest engine fixture in our test.

We should change all these assertion function to require an engine argument to avoid this.

(This was discovered in #22281 when changing the default to rapidsmpf change the behavior of some of these assertions)

cc @madsbk when you're adding Ray testing

Metadata

Metadata

Assignees

Labels

cudf-polarsIssues specific to cudf-polarsfeature requestNew feature or request

Type

No type

Projects

Status

Todo

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions