Add a board definition for the RP Debug Probe#2940
Open
carlwhamilton wants to merge 1 commit into
Open
Conversation
This minimal configuration will (hopefully) allow the Raspberry Pi Debug Probe firmware to be configured and built using the SDK's board identification and configuration framework.
Contributor
|
ping @P33M as he knows more about the Debug Probe hardware than I do. |
Author
|
After poking around some of the other board configuration files in the SDK, it appears that providing definitions for each of the Debug Probe's LEDs would be more idiomatic. I don't know the best way to propose these changes prior to adding them to the branch, so here is a specific commit that shows what I'm talking about. carlwhamilton/pico-sdk@d2eb3a3 If you think this is a better approach, let me know and I'll merge the commit into this branch. Thanks a lot.
|
Contributor
|
Yes, your suggestion certainly better-fits the style used by other board header files 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This minimal configuration will (hopefully) allow the Raspberry Pi Debug Probe firmware to be configured and built using the SDK's board identification and configuration framework.
Fixed #2939