Revamp build process#216
Draft
JayPanoz wants to merge 10 commits into
Draft
Conversation
cf. Cannot use both "packageManager" and "devEngines.packageManager" in package.json. "packageManager" will be ignored
Unsurprinsingly devEngines support is meh
PNPM treats github scheme as exotic subdependency so this is an issue for consumers of the project. Thorium locales not being a package with proper semver, fetch files manually – we need to run it manually anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rethinks how we build packages, starting with PNPM migration.