From 4588ca391647f67a3e4d5a0d55b99f3afc120afc Mon Sep 17 00:00:00 2001 From: TianyeDong Date: Sun, 5 Jul 2026 13:10:24 -0400 Subject: [PATCH] refactor(rlix): use shared is_rlix_mode() in multi_turn generate multi_turn defined a private _is_rlix_mode() that hand-copied the `os.environ.get("RLIX_CONTROL_PLANE") == "rlix"` check, duplicating the canonical helper in miles/utils/rlix_validation.py. Its stated reason was to avoid importing rlix_validation, but that module only depends on the stdlib (os/shutil/logging/typing), so importing it is free and cannot break importability. Import is_rlix_mode() directly, drop the duplicate function and the now unused `import os`. Co-Authored-By: Claude Opus 4.8 --- miles/rollout/generate_hub/multi_turn.py | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/miles/rollout/generate_hub/multi_turn.py b/miles/rollout/generate_hub/multi_turn.py index c1b1e41c70..e098482dce 100644 --- a/miles/rollout/generate_hub/multi_turn.py +++ b/miles/rollout/generate_hub/multi_turn.py @@ -13,7 +13,6 @@ """ import argparse -import os from copy import deepcopy from miles.rollout.base_types import ( @@ -36,13 +35,7 @@ ) from miles.utils.http_utils import post from miles.utils.misc import load_function - - -def _is_rlix_mode() -> bool: - """Mirror miles.utils.rlix_validation.is_rlix_mode without taking the - import dependency (multi_turn must remain importable even when the - rlix_validation module is absent in legacy installations).""" - return os.environ.get("RLIX_CONTROL_PLANE") == "rlix" +from miles.utils.rlix_validation import is_rlix_mode def _is_scheduler_preempt(output: dict, *, rlix_mode: bool) -> bool: @@ -83,7 +76,7 @@ async def generate(input: GenerateFnInput) -> GenerateFnOutput: # (F29 / C17): radix middleware is off, turn-level redispatch # requires non-streaming JSON, and partial_rollout has no place in # either mode. - rlix_mode = _is_rlix_mode() + rlix_mode = is_rlix_mode() assert not args.partial_rollout, ( "Partial rollout is not supported in multi_turn.generate (F29 / C17)" )