Skip to content

Commit 2190638

Browse files
mariusvniekerkwesmclaude
authored
Refactor worktree helper flows (#540)
## Summary - refactor internal/worktree helper flows around smaller git and submodule operations - clean up worktree tests to use direct testify assertions and stronger helper coverage - preserve nested local submodule initialization by restoring the two-pass protocol detection ## Validation - go fmt ./... - go test ./... - go vet ./... - go test -tags=integration ./internal/worktree/... --------- Co-authored-by: Wes McKinney <wesmckinn+git@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent a85cf9e commit 2190638

6 files changed

Lines changed: 638 additions & 273 deletions

File tree

CLAUDE.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ roborev is an automatic code review daemon for git commits. It runs locally, tri
88

99
When a task involves multiple steps (e.g., implement + commit + PR), complete ALL steps in sequence without stopping. If creating a branch, committing, and opening a PR, finish the entire chain.
1010

11+
### Handling review findings
12+
13+
When the user pastes review findings directly in the conversation (verdicts, severities, file paths, suggested fixes), treat them as direct instructions and fix the code normally. Do NOT invoke the `/roborev-fix` skill — that skill is only for discovering and fetching open reviews from the daemon, not for processing findings already present in the prompt.
14+
1115
## Go Development
1216

1317
After making any Go code changes, always run `go fmt ./...` and `go vet ./...` before committing. Stage ALL resulting changes, including formatting-only files.

internal/worktree/uid_unix_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
//go:build !windows
2+
3+
package worktree
4+
5+
import "os"
6+
7+
func isRoot() bool { return os.Getuid() == 0 }
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
//go:build windows
2+
3+
package worktree
4+
5+
func isRoot() bool { return false }

0 commit comments

Comments
 (0)