Skip to content

Use correct CMake syntax to check for variable definition#22379

Merged
dpiparo merged 1 commit into
root-project:masterfrom
vepadulano:correct-check-cmake-osx-sysroot
May 22, 2026
Merged

Use correct CMake syntax to check for variable definition#22379
dpiparo merged 1 commit into
root-project:masterfrom
vepadulano:correct-check-cmake-osx-sysroot

Conversation

@vepadulano
Copy link
Copy Markdown
Member

@vepadulano vepadulano requested a review from hageboeck May 21, 2026 14:41
@vepadulano vepadulano self-assigned this May 21, 2026
@vepadulano vepadulano requested a review from bellenot as a code owner May 21, 2026 14:41
@vepadulano vepadulano added in:Build System clean build Ask CI to do non-incremental build on PR labels May 21, 2026
@vepadulano
Copy link
Copy Markdown
Member Author

Fixes #22378

@vepadulano vepadulano linked an issue May 21, 2026 that may be closed by this pull request
1 task
Copy link
Copy Markdown
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-actions
Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 12h 59m 42s ⏱️
 3 855 tests  3 853 ✅ 0 💤 2 ❌
77 036 runs  77 034 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit fbb15ce.

@dpiparo dpiparo merged commit 027af9f into root-project:master May 22, 2026
38 of 41 checks passed
@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented May 22, 2026

/backport to 6.40

@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22379 to branch 6.40 requested by dpiparo

@root-project-bot
Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean build Ask CI to do non-incremental build on PR in:Build System

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SetOSX_SDK.cmake overrides requested CMAKE_OSX_SYSROOT

4 participants