fix: warm homepage metrics cache on first read - #74
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
rustfs-com | e07f5c1 | Commit Preview URL Branch Preview URL |
Aug 02 2026, 04:17 AM |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure the homepage metrics KV cache is proactively populated when the /api/homepage-metrics endpoint is first accessed, rather than only via the scheduled refresh.
Changes:
- Refactors KV reads into
readStoredMetrics()and introducesloadOrRefreshHomepageMetrics()to refresh metrics when the stored cache is missing/invalid. - Updates the Worker request path to use the new “load or refresh” behavior.
- Adds a GitHub Actions post-deploy step that calls the metrics endpoint to warm the cache.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| workers/homepage-metrics/src/index.ts | Adds “load or refresh” logic and uses it in the fetch handler to warm KV on cache miss. |
| workers/homepage-metrics/src/index.test.ts | Adds unit tests for the new “load or refresh” helper behavior. |
| .github/workflows/deploy-homepage-metrics.yml | Calls the metrics endpoint after deploy to warm the cache. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+227
to
+231
| const metrics = await loadOrRefreshHomepageMetrics( | ||
| () => readStoredMetrics(env), | ||
| () => refreshHomepageMetrics(env), | ||
| ); | ||
| return metricsResponse(metrics, request.method); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: warm homepage metrics cache on first read