Skip to content

Commit 244ea93

Browse files
zimegClaude
andcommitted
style(block-kit): omit emoji arg where the docs example omits emoji
Drop the explicit emoji=None on plain_text objects whose docs.slack.dev reference example omits the emoji field (feedback buttons, icon button, rich text input placeholder). slack_sdk drops None fields, so the serialized payload is unchanged — this only removes redundant source. emoji=True is kept where the docs example shows "emoji": true. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
1 parent 60c0b81 commit 244ea93

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎block-kit/src/elements/feedback_buttons.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ def example01() -> ContextActionsBlock:
1818
FeedbackButtonsElement(
1919
action_id="feedback_buttons_1",
2020
positive_button=FeedbackButtonObject(
21-
text=PlainTextObject(text="Good", emoji=None),
21+
text=PlainTextObject(text="Good"),
2222
value="positive_feedback",
2323
accessibility_label="Mark this response as good",
2424
),
2525
negative_button=FeedbackButtonObject(
26-
text=PlainTextObject(text="Bad", emoji=None),
26+
text=PlainTextObject(text="Bad"),
2727
value="negative_feedback",
2828
accessibility_label="Mark this response as bad",
2929
),

‎block-kit/src/elements/icon_button.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def example01() -> ContextActionsBlock:
1414
elements=[
1515
IconButtonElement(
1616
icon="trash",
17-
text=PlainTextObject(text="Delete", emoji=None),
17+
text=PlainTextObject(text="Delete"),
1818
action_id="delete_button",
1919
value="delete_item",
2020
),

‎block-kit/src/elements/rich_text_input.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def example01() -> View:
2121
"trigger_actions_on": ["on_character_entered"],
2222
},
2323
focus_on_load=True,
24-
placeholder=PlainTextObject(text="Enter text", emoji=None),
24+
placeholder=PlainTextObject(text="Enter text"),
2525
),
2626
label=PlainTextObject(text="Label", emoji=True),
2727
),

0 commit comments

Comments
 (0)