Skip to content

Set explicit coverage threshold#352

Draft
benni-rogge wants to merge 1 commit into
socketry:mainfrom
benni-rogge:baseline-coverage-threshold
Draft

Set explicit coverage threshold#352
benni-rogge wants to merge 1 commit into
socketry:mainfrom
benni-rogge:baseline-coverage-threshold

Conversation

@benni-rogge

@benni-rogge benni-rogge commented Jun 4, 2026

Copy link
Copy Markdown

Summary

covered:validate defaults to requiring 100% coverage, but the current main baseline is below that, so the Test Coverage / validate job is failing on main and on unrelated PRs.

Recent evidence:

I also checked the last five main Test Coverage / validate runs; all failed at the same baseline: 45 files checked; 755/882 lines executed; 85.6% covered.

This sets an explicit 85% validation threshold so the workflow matches the current project baseline and can catch future regressions without blocking unrelated changes.

Validation

The push workflow on my fork passed with this change, including Test Coverage / validate:

That job reported the current baseline, 45 files checked; 755/882 lines executed; 85.6% covered., and passed with the explicit --minimum 0.85 threshold.

I also validated the exact intended follow-up state for #351 by pushing a temporary fork branch that applies this PR first and then #351. That combined branch passed all workflows, including Test Coverage / validate:

That combined validation job reported: 45 files checked; 761/888 lines executed; 85.7% covered.

Notes

This is intended as a CI baseline fix. Raising coverage back to 100% can happen incrementally in follow-up test-only PRs.

@benni-rogge

Copy link
Copy Markdown
Author

Note: the workflow runs for this fork PR are currently waiting on maintainer approval (action_required). Once approved, the Test Coverage / validate job should use the explicit 85% threshold from this change.

@benni-rogge

benni-rogge commented Jun 4, 2026

Copy link
Copy Markdown
Author

Hi @ioquatix, could you please approve/run the workflows for this fork PR when you have a chance? This baseline CI fix is what unblocks #351 while keeping that PR focused.

Validation links:

@benni-rogge benni-rogge marked this pull request as draft June 4, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant