Set explicit coverage threshold#352
Draft
benni-rogge wants to merge 1 commit into
Draft
Conversation
Author
|
Note: the workflow runs for this fork PR are currently waiting on maintainer approval ( |
Author
|
Hi @ioquatix, could you please approve/run the workflows for this fork PR when you have a chance? This baseline CI fix is what unblocks #351 while keeping that PR focused. Validation links:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
covered:validatedefaults to requiring 100% coverage, but the currentmainbaseline is below that, so theTest Coverage / validatejob is failing onmainand on unrelated PRs.Recent evidence:
main(e7007f6):45 files checked; 755/882 lines executed; 85.6% covered.(run)Falcon::Middleware::Proxy#351 (6d54a53):45 files checked; 761/888 lines executed; 85.7% covered.(run)I also checked the last five
mainTest Coverage / validateruns; all failed at the same baseline:45 files checked; 755/882 lines executed; 85.6% covered.This sets an explicit 85% validation threshold so the workflow matches the current project baseline and can catch future regressions without blocking unrelated changes.
Validation
The push workflow on my fork passed with this change, including
Test Coverage / validate:That job reported the current baseline,
45 files checked; 755/882 lines executed; 85.6% covered., and passed with the explicit--minimum 0.85threshold.I also validated the exact intended follow-up state for #351 by pushing a temporary fork branch that applies this PR first and then #351. That combined branch passed all workflows, including
Test Coverage / validate:That combined validation job reported:
45 files checked; 761/888 lines executed; 85.7% covered.Notes
This is intended as a CI baseline fix. Raising coverage back to 100% can happen incrementally in follow-up test-only PRs.