From fd32a833ee3100d41a319c563a123ddb26d13512 Mon Sep 17 00:00:00 2001 From: Jan Obernberger Date: Mon, 1 Jun 2026 13:42:30 +0200 Subject: [PATCH 1/2] fix(secretsmanager): remove RequiresReplace for secretsmanager description --- stackit/internal/services/secretsmanager/user/resource.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/stackit/internal/services/secretsmanager/user/resource.go b/stackit/internal/services/secretsmanager/user/resource.go index 31777fafe..32268b56a 100644 --- a/stackit/internal/services/secretsmanager/user/resource.go +++ b/stackit/internal/services/secretsmanager/user/resource.go @@ -142,9 +142,6 @@ func (r *userResource) Schema(_ context.Context, _ resource.SchemaRequest, resp "description": schema.StringAttribute{ Description: descriptions["description"], Required: true, - PlanModifiers: []planmodifier.String{ - stringplanmodifier.RequiresReplace(), - }, }, "write_enabled": schema.BoolAttribute{ Description: descriptions["write_enabled"], @@ -415,7 +412,8 @@ func toUpdatePayload(model *Model) (*secretsmanager.UpdateUserPayload, error) { return nil, fmt.Errorf("nil model") } return &secretsmanager.UpdateUserPayload{ - Write: conversion.BoolValueToPointer(model.WriteEnabled), + Description: conversion.StringValueToPointer(model.Description), + Write: conversion.BoolValueToPointer(model.WriteEnabled), }, nil } From b2a94ef005ff89399d778a13b0870fd42b7a046d Mon Sep 17 00:00:00 2001 From: Jan Obernberger Date: Mon, 1 Jun 2026 13:42:51 +0200 Subject: [PATCH 2/2] fix(secretsmanager): adapt unit tests to also test description parameter --- .../secretsmanager/user/resource_test.go | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/stackit/internal/services/secretsmanager/user/resource_test.go b/stackit/internal/services/secretsmanager/user/resource_test.go index 4471e6a04..ff7360f23 100644 --- a/stackit/internal/services/secretsmanager/user/resource_test.go +++ b/stackit/internal/services/secretsmanager/user/resource_test.go @@ -234,17 +234,32 @@ func TestToUpdatePayload(t *testing.T) { "default_values", &Model{}, &secretsmanager.UpdateUserPayload{ - Write: nil, + Description: nil, + Write: nil, }, true, }, { "simple_values", &Model{ + Description: types.StringValue(""), WriteEnabled: types.BoolValue(false), }, &secretsmanager.UpdateUserPayload{ - Write: new(false), + Description: new(""), + Write: new(false), + }, + true, + }, + { + "only_description_updated", + &Model{ + Description: types.StringValue(""), + WriteEnabled: types.BoolNull(), + }, + &secretsmanager.UpdateUserPayload{ + Description: new(""), + Write: nil, }, true, },