fix: filter hidden files and directories from glob results in file_read#492
Open
xlyoung wants to merge 1 commit into
Open
fix: filter hidden files and directories from glob results in file_read#492xlyoung wants to merge 1 commit into
xlyoung wants to merge 1 commit into
Conversation
The search_file() function's os.walk path correctly prunes hidden directories and skips hidden files. However, the glob.glob() path (code line ~400) had no such filtering, causing files under hidden directories like .git/ to appear in search results. Add the same hidden file/directory filtering to glob results: skip any path where a component starts with '.'. Fixes strands-agents#289
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
search_file()function has two code paths:.git/,.venv/, etc. appear in resultsFix
Add the same hidden file/directory filtering to glob results:
This checks every path component (not just the filename) to catch files nested under hidden directories.
Testing
All 18 file_read tests pass.
Fixes #289