Skip to content

Support mobile, update zh-CN locales#488

Open
guyskk wants to merge 1 commit into
stringer-rss:mainfrom
guyskk:mobile
Open

Support mobile, update zh-CN locales#488
guyskk wants to merge 1 commit into
stringer-rss:mainfrom
guyskk:mobile

Conversation

@guyskk

@guyskk guyskk commented Sep 2, 2018

Copy link
Copy Markdown
Contributor

Before:

stringer-story-old
stringer-feeds-old

After:

stringer-story-new
stringer-feeds-new

@guyskk

guyskk commented Sep 2, 2018

Copy link
Copy Markdown
Contributor Author

I don't have permission to add translation in LocaleApp, how to participate in?

@duenni

duenni commented Sep 2, 2018

Copy link
Copy Markdown

Will this close #464?

@guyskk

guyskk commented Sep 3, 2018

Copy link
Copy Markdown
Contributor Author

@duenni No, but I can fix it in next commit.

If you device has very small screen(eg: IPhone 4), the layout may broken.

When screen is 375x667 pixel:
stringer-zero

When screen is 320x480 pixel:
stringer-broker

@guyskk

guyskk commented Sep 3, 2018

Copy link
Copy Markdown
Contributor Author

@duenni I just blamed the stylesheets source code, it shows the font-size not change in the last 5 years.
So it's not caused by stringer updates, did you tried other browers and devices?

@duenni

duenni commented Sep 3, 2018

Copy link
Copy Markdown

No, I did not try other devices. It's an iPhone SE, resolution should be 1136 x 640 px.

@mockdeep

Copy link
Copy Markdown
Collaborator

@guyskk I know it's been a couple of years, but are you still available to work on this? If so, I think it would be good to break up into separate PRs. One for the translations, one for the layout cleanups, and one for Turbolinks. I'm a little concerned about Turbolinks in particular, as that can cause issues depending on how the JavaScript is set up.

@guyskk

guyskk commented Feb 21, 2021

Copy link
Copy Markdown
Contributor Author

Hi @mockdeep, I didn't use stringer for a long time, and I have build another RSS reader https://github.com/anyant/rssant .

Please feel free to use my code and commits if you need.

@mockdeep

Copy link
Copy Markdown
Collaborator

@guyskk okay, I'll handle it, then. Thanks so much for contributing!

@bitboxer

Copy link
Copy Markdown
Contributor

@mockdeep would love to have those css fixes merged. Should I take over the fixing of this pr?

@mockdeep

Copy link
Copy Markdown
Collaborator

@bitboxer that would be great! If you want to separate out the CSS changes, I'll be happy to review them and get them merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants