Updated get_constituent_citations#39
Open
FusionSandwich wants to merge 1 commit into
Open
Conversation
gonuke
requested changes
Aug 9, 2024
Member
gonuke
left a comment
gonuke
left a comment
There was a problem hiding this comment.
Nice catch - I've offered some options that avoid the successive append() approach. Sometimes it's necessary to explicitly append something in a loop, but here a python list comprehension may be a better choice.
Member
The comment I made above was marked as resolved and given a 👍 , but there as no subsequent commit to make the change.... it may not be worth blocking the merge, but I was expecting to see an update (which would have ended up i my queue and had this merged long ago) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the spelling of consituent to constituent, added doc strings, and updated get_constituent_citations to separate citations with a ",".