Apply babbaj's second review of the Java pathfinder - #21
Merged
Merged
Conversation
Brings back 0Mattias/baritone 8827e157 from the fork's java-nether-pathfinder branch, the commit cabaletta/baritone#5117 now carries, as #20 did for the first review. The x8 summary bit is cleared with its cube's last block again, but only for the single block updates from queueBlockUpdate, which pass a new `exact` flag to Chunk.setBlock; the callers that fill a whole chunk at once only ever set blocks, so they keep the four-argument form and skip the scan. Two comments babbaj asked to drop are gone, and so are four unused imports. The pathfinder package stays byte for byte the branch's, modulo the package name and the licence header. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
babbaj's second pass on cabaletta/baritone#5117 had three notes, and this brings them back from the fork's
java-nether-pathfinderbranch (0Mattias/baritone8827e157), the way #20 did for the first review.queueBlockUpdateclears single blocks in chunks the search is using, so it passes a newexactflag toChunk.setBlockthat clears the cube's bit with its last block; the callers that fill a whole chunk at once only ever set blocks, so they keep the four-argument form and skip the scanCachedRegion.CACHED_REGION_MAGICand onPathSegment.blocks)The pathfinder package stays byte for byte the branch's, modulo the package name and the licence header, and
ChunkTestnow checks both kinds of clear. All 102 unit tests pass locally.🤖 Generated with Claude Code