This repository was archived by the owner on Dec 4, 2024. It is now read-only.
Wait to join consensus until synced with best peer - #2020
Open
goran-ethernal wants to merge 3 commits into
Open
goran-ethernal wants to merge 3 commits into
goran-ethernal wants to merge 3 commits into
Conversation
goran-ethernal
force-pushed
the
wait-for-synced-fix
branch
from
October 30, 2023 14:09
f07ab45 to
e0df051
Compare
goran-ethernal
marked this pull request as ready for review
October 30, 2023 17:43
goran-ethernal
force-pushed
the
wait-for-synced-fix
branch
from
October 31, 2023 08:03
e0df051 to
87c97e8
Compare
goran-ethernal
requested review from
Stefan-Ethernal,
begmaroman,
rachit77 and
vcastellm
October 31, 2023 09:34
Stefan-Ethernal
approved these changes
Nov 2, 2023
added 3 commits
November 6, 2023 10:33
goran-ethernal
force-pushed
the
wait-for-synced-fix
branch
from
November 6, 2023 09:33
2efd42c to
df57c25
Compare
|
SonarCloud Quality Gate failed.
|
vcastellm
approved these changes
Dec 15, 2023
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a wait mechanism when starting the node in
polybft, which stops the validator node from joining consensus until synced with best peer.This helps stability and unnecessary network traffic, since validators that are syncing are proposing invalid blocks, until they sync up fully, and rejoin consensus.
Changes include
Checklist
Testing