-
Notifications
You must be signed in to change notification settings - Fork 131
perf(types): точечная инвалидация memo членов вместо глобальной эпохи #4280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nixel2007
wants to merge
7
commits into
develop
Choose a base branch
from
perf/type-members-per-document-invalidation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cebe570
perf(types): точечная инвалидация memo членов вместо глобальной эпохи
nixel2007 901aa63
fix(types): защита точечной инвалидации memo от гонки публикации (рев…
nixel2007 880d75d
refactor(types): убрать поколение name-индекса, кэшировать его по наб…
nixel2007 a6ac748
build: включить zip64 для jmhJar
nixel2007 9f7eed9
test(jmh): бенчмарк горячего пути getMembers и цены пер-типового поко…
nixel2007 6d1e8f5
refactor(types): замечания ревью по name-индексу и усиление теста инв…
nixel2007 ea8e728
perf(types): точечная инвалидация memo и для OScript вместо глобально…
nixel2007 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift
Make targeted invalidation generation-based.
Both APIs clear cached values without changing a version, allowing an in-flight stale computation to republish data after invalidation.
src/main/java/com/github/_1c_syntax/bsl/languageserver/types/registry/TypeRegistry.java#L608-L611: increment a canonical per-type generation and validate it ingetMembers; this should also cover alternateTypeRefs resolving to the same source.src/main/java/com/github/_1c_syntax/bsl/languageserver/types/registry/GlobalScopeProvider.java#L175-L176: include theGLOBAL_CONTEXTgeneration inGlobalIndexand reject publication from an older generation.📍 Affects 2 files
src/main/java/com/github/_1c_syntax/bsl/languageserver/types/registry/TypeRegistry.java#L608-L611(this comment)src/main/java/com/github/_1c_syntax/bsl/languageserver/types/registry/GlobalScopeProvider.java#L175-L176🤖 Prompt for AI Agents