๐จ [Refactoring] Admin ๊ณต์ ์ผ์ ์กฐํ API -> ๋ถ๋ฅ๋ณ ์ผ์ ์กฐํ API๋ก ๋ณ๊ฒฝ #1091#1093
Open
seyeon22222 wants to merge 5 commits into
Hidden character warning
The head ref may contain hidden characters: "1091-refactoring-admin-\uacf5\uc720\uc77c\uc815-\uc870\ud68c-api---\ubd84\ub958\ubcc4-\uc77c\uc815\uc870\ud68c-api\ub85c-\ubcc0\uacbd"
Conversation
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests โ
Additional details and impacted files@@ Coverage Diff @@
## dev #1093 +/- ##
============================================
+ Coverage 74.42% 76.99% +2.57%
- Complexity 1227 1691 +464
============================================
Files 399 574 +175
Lines 5524 7780 +2256
Branches 440 525 +85
============================================
+ Hits 4111 5990 +1879
- Misses 1220 1547 +327
- Partials 193 243 +50
Flags with carried forward coverage won't be shown. Click here to find out more. โ View full report in Codecov by Sentry. |
wonies
previously approved these changes
Dec 31, 2024
wonies
left a comment
wonies
left a comment
Contributor
There was a problem hiding this comment.
๋ก์ง ๋ฐ๊พธ์๋๋ผ ๊ณ ์๋ง์ผ์ จ์ต๋๋ค!
| private MockMvc mockMvc; | ||
|
|
||
| @Autowired | ||
| EntityManager em; |
Contributor
There was a problem hiding this comment.
em์ ์ฐ๋ ๋ถ๋ถ์ด ์๋๋ฐ, ์ด๊ฑด ๊ทธ๋ฅ ์ ์ธํด๋ ๋๋ ๊ฑด๊ฐ์? ๊ถ๊ธํด์ ์ฌ์ญค๋ด ๋๋ท
wonies
reviewed
Jan 6, 2025
| Page<PublicSchedule> publicSchedules = publicScheduleAdminRepository.findAllByClassification( | ||
| detailClassification, pageable); | ||
|
|
||
| List<TotalScheduleAdminResDto> publicScheduleList = publicSchedules.stream() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
๐ ๊ฐ์
๐ป ์์ ์ฌํญ
โ ๋ณ๊ฒฝ๋ก์ง
๐กIssue ๋ฒํธ