Skip to content

Factor expression validator warnings #8569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4ian wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −3
Open

Factor expression validator warnings #8569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Core/GDCore/IDE/Events/ExpressionValidator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,13 +298,11 @@ ExpressionValidator::Type ExpressionValidator::ValidateFunction(
// Check if the expression is deprecated
if (metadata.IsDeprecated()) {
gd::String deprecationMessage = metadata.GetDeprecationMessage();
auto diagnostic = gd::make_unique<ExpressionParserError>(
RaiseWarning(
gd::ExpressionParserError::ErrorType::DeprecatedExpression,
_("This expression is deprecated.") +
(deprecationMessage.empty() ? "" : " " + deprecationMessage),
function.location);
deprecationWarnings.push_back(diagnostic.get());
supplementalErrors.push_back(std::move(diagnostic));
}

// Validate the type of the function
Expand Down
14 changes: 14 additions & 0 deletions Core/GDCore/IDE/Events/ExpressionValidator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,20 @@ class GD_CORE_API ExpressionValidator : public ExpressionParser2NodeWorker {
supplementalErrors.push_back(std::move(diagnostic));
}

void RaiseWarning(gd::ExpressionParserError::ErrorType type,
const gd::String &message,
const ExpressionParserLocation &location,
const gd::String &actualValue = "",
const gd::String &objectName = "") {
auto diagnostic = gd::make_unique<ExpressionParserError>(
type, message, location, actualValue, objectName);
deprecationWarnings.push_back(diagnostic.get());
// Warnings found by the validator are not holden by the AST nodes.
// They must be owned by the validator to keep living while warnings are
// handled by the caller.
supplementalErrors.push_back(std::move(diagnostic));
}

void RaiseUnknownIdentifierError(const gd::String &message,
const ExpressionParserLocation &location) {
RaiseError(gd::ExpressionParserError::ErrorType::UnknownIdentifier, message,
Expand Down
Loading