Fusing Pallas Layout Transposes and Output Projections#449
Closed
prishajain1 wants to merge 1 commit into
Closed
Conversation
prishajain1
marked this pull request as draft
July 18, 2026 04:58
prishajain1
force-pushed
the
fuse-transposes
branch
from
July 18, 2026 05:07
c6b1fed to
c001267
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes the custom sequence-parallel attention path for WAN models by fusing layout transposes and avoiding post-attention copy overhead.
Changes:
custom_splash_attention.py): Modified forward kernels to write output registers directly in transposed[H, S, D]layout using SRAM transposes.attention_flax.py): Bypassed post-attentionjnp.swapaxesand_reshape_heads_to_head_dimtranspose copy operations for custom kernels.FlaxWanAttention): Implemented a custom multi-axisdot_generalcontraction contracting theH(heads) andD(head features) axes directly, avoiding transposing activations before matrix multiplication.Performance and Results:
Eliminates layout transpose overhead after the Ulysses
all_to_allcollective: