Skip to content

Fix compile_cache_test flakiness caused by the persistent cache compile time threshold #4692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bzantium wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Fix compile_cache_test flakiness caused by the persistent cache compile time threshold #4692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/unit/compile_cache_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,11 @@ def test_train_step_cache_hit():
env["JAX_ENABLE_COMPILATION_CACHE"] = "true"
env["JAX_COMPILATION_CACHE_DIR"] = temp_dir
env["JAX_LOG_COMPILES"] = "1"
# JAX only caches a computation whose compilation is slower than this
# threshold, which defaults to 1 second. The model here is small enough that
# the AOT compilation can finish below it, so the cache is left empty and the
# runtime execution has nothing to hit.
env["JAX_PERSISTENT_CACHE_MIN_COMPILE_TIME_SECS"] = "0"

print("Running CPU training subprocess:", " ".join(cmd))
result = subprocess.run(cmd, env=env, capture_output=True, text=True, check=True)
Expand Down
Loading