Skip to content
This repository was archived by the owner on Jul 22, 2026. It is now read-only.

pin liteLLM - #775

Merged
akihikokuroda merged 3 commits into
AI4quantum:mainfrom
akihikokuroda:pinlitellm
Apr 7, 2026
Merged

pin liteLLM#775
akihikokuroda merged 3 commits into
AI4quantum:mainfrom
akihikokuroda:pinlitellm

Conversation

@akihikokuroda

Copy link
Copy Markdown
Member

Pin liteLLM to safe version.

Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda
akihikokuroda requested a review from a team as a code owner April 7, 2026 12:31

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds litellm version 1.82.6 to the project dependencies. Feedback suggests using a version range instead of an exact pin to avoid potential dependency conflicts for downstream users.

Comment thread pyproject.toml Outdated
"psutil>=7.0.0",
"openapi>=2.0.0",
"openai-agents[litellm]>=0.0.14",
"litellm==1.82.6",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Pinning a dependency to an exact version (==) in pyproject.toml is generally discouraged for libraries and frameworks. This practice can lead to dependency conflicts for downstream users who might require a different version of the same package in their environment. Since the goal is to ensure a 'safe version' (likely addressing a security vulnerability or a specific bug), it is recommended to use a version range (e.g., >=1.82.6) or a compatible release specifier (e.g., ~=1.82.6). This ensures the minimum safe version is used while allowing for future patch updates and improving compatibility with other packages.

Suggested change
"litellm==1.82.6",
"litellm>=1.82.6",

Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
f"Expected import error, got: {error_msg}",
)

@pytest.mark.skip(reason="Disabled for pytest")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reason to disable these?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These failed and I didn't think it worth to spend time to investigate.

@akihikokuroda
akihikokuroda merged commit 3316fc8 into AI4quantum:main Apr 7, 2026
12 of 14 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants