Skip to content

Align smoothstep edge cases with OSL #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jstone-lucasfilm merged 3 commits into from
Sep 5, 2024
+3 −3
Merged

Align smoothstep edge cases with OSL #1985

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29be0f0
Align GLSL/MSL code for smoothstep with OSL (https://github.com/Acade…
ld-kerley Aug 21, 2024
b503702
Fix typo
ld-kerley Aug 22, 2024
75a78dd
Merge branch 'main' into align_smoothstep_code_with_OSL
jstone-lucasfilm Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libraries/stdlib/genglsl/mx_smoothstep_float.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
void mx_smoothstep_float(float val, float low, float high, out float result)
{
if (val <= low)
result = 0.0;
else if (val >= high)
if (val >= high)
result = 1.0;
else if (val <= low >)
Comment thread
jstone-lucasfilm marked this conversation as resolved.
Outdated
result = 0.0;
else
result = smoothstep(low, high, val);
}