Skip to content

proxy: preserve zero TTL in respectTTLOverrides #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hengwu0 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

proxy: preserve zero TTL in respectTTLOverrides #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion proxy/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ func minTTL(h *dns.RR_Header, ttl uint32) uint32 {
// Updates a given TTL to fall within the range specified by the cacheMinTTL and
// cacheMaxTTL settings.
func respectTTLOverrides(ttl, cacheMinTTL, cacheMaxTTL uint32) uint32 {
if ttl < cacheMinTTL {
if 0 < ttl && ttl < cacheMinTTL {
return cacheMinTTL
}

Expand Down
26 changes: 26 additions & 0 deletions proxy/cache_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,32 @@ func TestCacheExpirationWithTTLOverride(t *testing.T) {
require.NotNil(t, ci)
assert.Equal(t, dnsProxy.CacheMaxTTL, ci.m.Answer[0].Header().Ttl)
})

t.Run("preserve_zero", func(t *testing.T) {
d.Req = newHostTestMessage("host3")
d.Addr = netip.AddrPort{}

u.ans = []dns.RR{&dns.A{
Hdr: dns.RR_Header{
Rrtype: dns.TypeA,
Name: "host3.",
Ttl: 0,
},
A: net.IP{4, 3, 2, 1},
}}

err := dnsProxy.Resolve(testutil.ContextWithTimeout(t, defaultTimeout), d)
require.NoError(t, err)

require.NotNil(t, d.Res)
require.Len(t, d.Res.Answer, 1)
assert.Zero(t, d.Res.Answer[0].Header().Ttl)

ci, expired, key := dnsProxy.cache.get(d.Req)
assert.False(t, expired)
assert.Equal(t, msgToKey(d.Req), key)
assert.Nil(t, ci)
})
}

type testEntry struct {
Expand Down