Update plugins.md removed wrong example of plugin usage and added right one - #458
Open
ndpatelce05 wants to merge 1 commit into
Open
Update plugins.md removed wrong example of plugin usage and added right one#458ndpatelce05 wants to merge 1 commit into
ndpatelce05 wants to merge 1 commit into
Conversation
Docs: Replace incorrect __construct plugin example with valid magic method example. Removed an invalid example showing a plugin applied to the __construct method, which contradicts documented plugin limitations. Replaced it with a functional example of intercepting PHP magic methods (__get and __call) based on verified community solutions on https://magento.stackexchange.com/questions/309817/how-to-change-product-images-with-external-image-url-in-all-magento-2-frontend-a#answer-309826
Author
|
I have already signed Adobe CLA still the status is not updated in this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Docs: Replace incorrect __construct plugin example with valid magic method example. Removed an invalid example showing a plugin applied to the __construct method, which contradicts documented plugin limitations. Replaced it with a functional example of intercepting PHP magic methods (__get and __call) based on verified community solutions on https://magento.stackexchange.com/questions/309817/how-to-change-product-images-with-external-image-url-in-all-magento-2-frontend-a#answer-309826
Affected pages
https://developer.adobe.com/commerce/php/development/components/plugins
Links to Magento Open Source code