Skip to content

Inject Pooling Connection Manager #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielrohe wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Inject Pooling Connection Manager #2025

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40ef327
possibility to inject connection manager
danielrohe Aug 7, 2026
7f1e3bd
added review findings
danielrohe Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions src/main/java/com/adyen/httpclient/AdyenHttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@
import org.apache.hc.client5.http.config.ConnectionConfig;
import org.apache.hc.client5.http.config.RequestConfig;
import org.apache.hc.client5.http.impl.classic.CloseableHttpClient;
import org.apache.hc.client5.http.impl.classic.HttpClientBuilder;
import org.apache.hc.client5.http.impl.classic.HttpClients;
import org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager;
import org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManagerBuilder;
import org.apache.hc.client5.http.ssl.SSLConnectionSocketFactory;
import org.apache.hc.core5.http.HttpHost;
Expand Down Expand Up @@ -91,9 +93,18 @@ public class AdyenHttpClient implements ClientInterface {

private static final String CHARSET = "UTF-8";
private Proxy proxy;
private PoolingHttpClientConnectionManager sharedConnectionManager;
private volatile CloseableHttpClient sharedHttpClient;
private final Object lock = new Object();

public AdyenHttpClient() {
super();
}

public AdyenHttpClient(PoolingHttpClientConnectionManager connectionManager) {
this.sharedConnectionManager = connectionManager;
}
Comment thread
danielrohe marked this conversation as resolved.
Outdated

/**
* Returns the proxy configured for this HTTP client.
*
Expand Down Expand Up @@ -372,7 +383,12 @@ private CloseableHttpClient createHttpClientWithSocketFactory(
config.getConnectionRequestTimeoutMillis(), TimeUnit.MILLISECONDS)
.setDefaultKeepAlive(config.getDefaultKeepAliveMillis(), TimeUnit.MILLISECONDS)
.build();
ConnectionConfig connectionConfig =

HttpClientBuilder clientBuilder = HttpClients.custom();
if (sharedConnectionManager != null) {
clientBuilder = clientBuilder.setConnectionManager(sharedConnectionManager).setConnectionManagerShared(true);
} else {
ConnectionConfig connectionConfig =
ConnectionConfig.custom()
.setConnectTimeout(config.getConnectionTimeoutMillis(), TimeUnit.MILLISECONDS)
// socketTimeout acts as an OS-level safety net for stalled reads;
Expand All @@ -381,12 +397,14 @@ private CloseableHttpClient createHttpClientWithSocketFactory(
// fires first.
.setSocketTimeout(config.getReadTimeoutMillis(), TimeUnit.MILLISECONDS)
.build();
return HttpClients.custom()
.setConnectionManager(
clientBuilder = clientBuilder.setConnectionManager(
PoolingHttpClientConnectionManagerBuilder.create()
.setSSLSocketFactory(socketFactory)
.setDefaultConnectionConfig(connectionConfig)
.build())
.build());
}

return clientBuilder
.setDefaultRequestConfig(defaultRequestConfig)
.setRedirectStrategy(new AdyenCustomRedirectStrategy())
.build();
Expand Down