feat(control-plane): expose furrow_public_addr in health - #888
Closed
AbirAbbas wants to merge 1 commit into
Closed
Conversation
The desktop's workspace-sync probe (PR #885) reads furrow_public_addr from the health response body, but nothing emitted the field, so the probe could never report availability. Emit it from the shared health handler when the FURROW_PUBLIC_ADDR env var is set; omit the key entirely when it is not. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Folded into #890 — same story, one PR instead of three. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The desktop's workspace-sync probe (merged in #885,
furrowAddressFromindesktop/src/main/cloud.ts) reads afurrow_public_addrfield from the control plane's health response — but no control-plane version emits that field, sofurrowAvailablecan never be true, even on a deployment where workspace sync is fully provisioned and reachable. Found while e2e-testing #885 + Agent-Field/SWE-AF#130 against a live cloud deployment.Changes Made
GET /healthandGET /api/v1/health) now includes top-levelfurrow_public_addrwhen theFURROW_PUBLIC_ADDRenv var is non-empty — the var the deploy engine already sets on provisioned services. When unset, the key is absent (not empty), matching what the desktop probe expects.TestHealthCheckHandlerFurrowPublicAddr).Test Plan
go test ./internal/server(new subtestsset/emptypass)go build ./...,go vet ./..., gofmt clean🤖 Generated with Claude Code