You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
uv run --frozen pytest tests/test_agent_networking.py -q (15 passed)
uv run --frozen ruff check agentfield/agent.py tests/test_agent_networking.py
uv run --frozen ruff format --check agentfield/agent.py tests/test_agent_networking.py
git diff --check
Full suite: 11 failures unrelated to this change (Windows shell/encoding assumptions in test_harness_packaging.py and test_run_cli_env.py); remaining tests passed, 6 skipped.
Thanks for jumping on this — and sorry for the collision: #969 went up within seconds of this one and covers the same opt-out plus the case pocesar actually reported in #624 (the probe firing even though a callback URL is already configured — #969 skips detection automatically whenever callback_url / AGENT_CALLBACK_URL is set, and adds AGENTFIELD_DISABLE_IP_DETECTION for containers with no callback URL at all), with a tripwire test that requests.get is never reached and a docs entry. Since #969 is already reviewed and queued, I'm closing this one rather than carry two fixes for one issue. One note for next time: about two thirds of this diff is ruff format reflow of untouched code in agent.py — the repo has pre-existing drift there and CI doesn't gate formatting, so keeping diffs to the hunks you mean to change makes review much faster. Your #947 is in the merge queue, by the way — thanks for that one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #624
Validation
uv run --frozen pytest tests/test_agent_networking.py -q(15 passed)uv run --frozen ruff check agentfield/agent.py tests/test_agent_networking.pyuv run --frozen ruff format --check agentfield/agent.py tests/test_agent_networking.pygit diff --checktest_harness_packaging.pyandtest_run_cli_env.py); remaining tests passed, 6 skipped.