Repository navigation
fix(types): make createTooltip modifiers optional - #1110
Open
Hugohong258 wants to merge 1 commit into
Open
Hugohong258 wants to merge 1 commit into
Hugohong258 wants to merge 1 commit into
Conversation
✅ Deploy Preview for v-tooltip ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented
createTooltip(el, value)call works at runtime but fails TypeScript checking because the inferred declaration requiresmodifiers. Mark that parameter optional and add coverage for omitted modifiers and an explicit placement modifier.Fixes #1083. The generated JavaScript artifacts are byte-for-byte identical before and after this annotation change.
Validation: the two-argument regression fails the source typecheck and a strict consumer check against the built CommonJS declaration before the fix; both pass afterward. The library build, all 33 Vitest tests, and ESLint for both changed files pass under Node 24.15.0 with the repository's pnpm 12.3.4. The build retains its existing mixed named/default export warning. Browser end-to-end tests and other interpreter/platform versions were not run. No generated files or lockfiles are changed.
git diff --checkpasses.