ci: add GitHub Actions workflow for bun and pnpm verification - #3
Merged
Conversation
PluginDatabase installs with pnpm while development uses bun, so both install paths are exercised in parallel jobs with frozen lockfiles to catch a stale or divergent lockfile before it reaches a release or the plugin database.
Main-branch runs validate merge results that the corresponding PR run never tested, so back-to-back merges must not cancel them.
The package.json/plugin.json version invariant was previously enforced only by the release script, so drift could sit unnoticed until a release was attempted.
Owner
Author
|
Addressed review findings #2 and #4:
#1 (pinning Bun) and #3 (Node pin/caching) intentionally skipped: #1 is a float-vs-pin trade-off with a benign, visible failure mode, and #3 was self-rated as not worth it at this job duration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the repo's first CI workflow: two parallel jobs that both run typecheck, tests, and a production build.
Jobs
bun ci(frozen lockfile install), then typecheck / test / build. The primary gate.pnpm install --frozen-lockfile, then the same three commands through pnpm. Mirrors how PluginDatabase installs and builds plugins, so a stale or divergentpnpm-lock.yamlfails here before it reaches a release or the plugin database PR.Notes
ubuntu-latest; Bun is installed in the pnpm job too because the test script isbun test.lockfileVersion: 9.0format. PluginDatabase itself uses unpinned latest pnpm; if that ever matters we can revisit.package.json. Cross-lockfile divergence (both fresh but resolving differently) is intentionally not checked yet.mainand all pull requests; superseded runs are cancelled via a concurrency group.Testing