Skip to content

Avoid casting empty buffer to ITS/MFT CTF ref. #15483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahor02 merged 1 commit into from
Jun 4, 2026
+8 −6
Merged

Avoid casting empty buffer to ITS/MFT CTF ref. #15483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions Detectors/ITSMFT/common/workflow/src/EntropyDecoderSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,26 +71,28 @@ void EntropyDecoderSpec<N>::run(ProcessingContext& pc)
auto buff = pc.inputs().get<gsl::span<o2::ctf::BufferType>>(getBinding(nm + "CTF", iLayer));
// since the buff is const, we cannot use EncodedBlocks::relocate directly, instead we wrap its data to another flat object
// const auto ctfImage = o2::itsmft::CTF::getImage(buff.data());
const auto& ctf = o2::itsmft::CTF::getImage(buff.data());
if (ctf.getHeader().maxStreams != nLayers) {
LOGP(fatal, "Number of streams {} in the CTF header is not equal to NLayers {} from AlpideParam in {}staggered mode",
ctf.getHeader().maxStreams, nLayers, mDoStaggering ? "" : "non-");
if (buff.size()) {
const auto& ctf = o2::itsmft::CTF::getImage(buff.data());
if (ctf.getHeader().maxStreams != nLayers) {
LOGP(fatal, "Number of streams {} in the CTF header is not equal to NLayers {} from AlpideParam in {}staggered mode",
ctf.getHeader().maxStreams, nLayers, mDoStaggering ? "" : "non-");
}
}
// this produces weird memory problems in unrelated devices, to be understood
// auto& trigs = pc.outputs().make<std::vector<o2::itsmft::PhysTrigger>>(OutputRef{"phystrig"}); // dummy output
auto& rofs = pc.outputs().make<std::vector<o2::itsmft::ROFRecord>>(OutputRef{nm + "ROframes", iLayer});
if (mGetDigits) {
auto& digits = pc.outputs().make<std::vector<o2::itsmft::Digit>>(OutputRef{nm + "Digits", iLayer});
if (buff.size()) {
iosize += mCTFCoder.decode(ctf, rofs, digits, mNoiseMap, mPattIdConverter);
iosize += mCTFCoder.decode(o2::itsmft::CTF::getImage(buff.data()), rofs, digits, mNoiseMap, mPattIdConverter);
}
ndigcl += digits.size();
nrofs += rofs.size();
} else {
auto& compcl = pc.outputs().make<std::vector<o2::itsmft::CompClusterExt>>(OutputRef{nm + "compClusters", iLayer});
auto& patterns = pc.outputs().make<std::vector<unsigned char>>(OutputRef{nm + "patterns", iLayer});
if (buff.size()) {
iosize += mCTFCoder.decode(ctf, rofs, compcl, patterns, mNoiseMap, mPattIdConverter);
iosize += mCTFCoder.decode(o2::itsmft::CTF::getImage(buff.data()), rofs, compcl, patterns, mNoiseMap, mPattIdConverter);
}
ndigcl += compcl.size();
}
Expand Down