Skip to content

[Common,PWGLF] Add outer and rct info and converter to multBC table for centrality studies#16516

Open
jesgum wants to merge 7 commits into
AliceO2Group:masterfrom
jesgum:cent-study-tables
Open

[Common,PWGLF] Add outer and rct info and converter to multBC table for centrality studies#16516
jesgum wants to merge 7 commits into
AliceO2Group:masterfrom
jesgum:cent-study-tables

Conversation

@jesgum

@jesgum jesgum commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

This pr adds the rct info and the FT0A and FV0 outer rings to the multBC datamodel which is primarily used for the centrality studies. For backwards compatibility this is done by versioning the tables and adding a converter, in case one runs on derived data generated before this pr.

Tagging @abmodak since I needed to change the table subscription in his task

@github-actions github-actions Bot changed the title Add outer and rct info and converter to multBC table for centrality studies [Common,PWGLF] Add outer and rct info and converter to multBC table for centrality studies Jun 3, 2026
@github-actions

github-actions Bot commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 20 errors, ⚠️ 12 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Jun 3, 2026
Merged
jesgum and others added 2 commits June 3, 2026 10:40
@jesgum jesgum marked this pull request as ready for review June 3, 2026 09:00
@alibuild

alibuild commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 8b210d5 at 2026-06-04 14:05:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for ce6f63b at 2026-06-03 18:18:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 8b210d5 at 2026-06-09 23:14:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: interrupted by user.

Full log here.

ddobrigk
ddobrigk previously approved these changes Jun 10, 2026
View reviewed changes
@alibuild

alibuild commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for a72ebe2 at 2026-06-10 10:59:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:959:45: error: 'struct o2::soa::Table<o2::aod::Hash<700517410>, o2::aod::Hash<324924961>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<700517410>, o2::aod::Hash<324924961>, o2::aod::Hash<2286545062> > >' has no member named 'timestamp'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:981:100: error: 'struct o2::soa::Table<o2::aod::Hash<700517410>, o2::aod::Hash<324924961>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<700517410>, o2::aod::Hash<324924961>, o2::aod::Hash<2286545062> > >' has no member named 'multFT0PosZ'; did you mean 'multFT0A'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:959:45: error: 'struct o2::soa::Table<o2::aod::Hash<700517410>, o2::aod::Hash<324924961>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<700517410>, o2::aod::Hash<324924961>, o2::aod::Hash<2286545062> > >' has no member named 'timestamp'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:981:100: error: 'struct o2::soa::Table<o2::aod::Hash<700517410>, o2::aod::Hash<324924961>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<700517410>, o2::aod::Hash<324924961>, o2::aod::Hash<2286545062> > >' has no member named 'multFT0PosZ'; did you mean 'multFT0A'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:959:45: error: 'struct o2::soa::Table<o2::aod::Hash<700517410>, o2::aod::Hash<324924961>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<700517410>, o2::aod::Hash<324924961>, o2::aod::Hash<2286545062> > >' has no member named 'timestamp'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tasks/centralityStudy.cxx:981:100: error: 'struct o2::soa::Table<o2::aod::Hash<700517410>, o2::aod::Hash<324924961>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<700517410>, o2::aod::Hash<324924961>, o2::aod::Hash<2286545062> > >' has no member named 'multFT0PosZ'; did you mean 'multFT0A'?
ninja: build stopped: subcommand failed.

Full log here.

abmodak
abmodak previously approved these changes Jun 10, 2026
View reviewed changes

@abmodak abmodak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the PR as per changes in heayionMultiplicity task

@jesgum

jesgum commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

I approve the PR as per changes in heayionMultiplicity task

Thanks @abmodak! I accidentally broke the compilation when trying to resolve a conflict, which is now fixed. Could you re-approve?

@alibuild

alibuild commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 52ab99a at 2026-06-13 22:48:

## sw/BUILD/O2Physics-latest/log
2026-06-13T22:46:19.305+0200 [22950:140486082141824] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.306+0200 [22950:140486082141824] [executioncontext.cpp:739] [ERROR] Failed to download output blob 568adb78c821b6e4e576ded536e07484da67e305603c67f71559005101b6afe4: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22874:140329875459712] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.306+0200 [22874:140329875459712] [executioncontext.cpp:739] [ERROR] Failed to download output blob 75f181afee9b08498d4bf9939c304b09916d60303673edbea300483d0c02ac77: 14: Socket closed
2026-06-13T22:46:19.305+0200 [23121:140415976136320] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.306+0200 [23121:140415976136320] [executioncontext.cpp:739] [ERROR] Failed to download output blob 8505bceb93c1f14a7bc958d988f81ad607b1d63242f2a3dd6e4c589ba3b74932: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22877:140608695713408] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.306+0200 [22877:140608695713408] [executioncontext.cpp:739] [ERROR] Failed to download output blob 29fac5e901334e43cd73cc692e71700fa9697586f1bff17a5667c18fd528a606: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22828:140335567126144] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.306+0200 [22828:140335567126144] [executioncontext.cpp:739] [ERROR] Failed to download output blob 43f1b28145573a54097d5275c9d6b45efe14cfe2d4e64362a496fe648ba8e800: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22927:139985373068928] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.306+0200 [22927:139985373068928] [executioncontext.cpp:739] [ERROR] Failed to download output blob 78bf8feed5fd2ecf25947be9f557d43faba1554f76284ed6ab289a83cd12e8a4: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22994:140079792893568] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.306+0200 [22994:140079792893568] [executioncontext.cpp:739] [ERROR] Failed to download output blob be6820f4b2009076b87fb6844e4553ad59e12bc6729d096038be52dd2474a973: 14: Socket closed
2026-06-13T22:46:19.305+0200 [23091:140599507918464] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.306+0200 [23091:140599507918464] [executioncontext.cpp:739] [ERROR] Failed to download output blob b71c71e560a24373683d362520dba8bdf34de17a18ea83d0609c0e305e868373: 14: Socket closed
2026-06-13T22:46:19.305+0200 [23041:140055088365184] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "BatchReadBlobs()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.306+0200 [23041:140055088365184] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-06-13T22:46:19.307+0200 [23041:140055088365184] [executioncontext.cpp:739] [ERROR] Failed to download output blob 0f9065706ff4df7506f3070ac541168d12bcdb28f2d8daddc50c6aa30bf8a2d0: 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-06-13T22:46:19.305+0200 [22806:139649528946304] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.306+0200 [22806:139649528946304] [executioncontext.cpp:739] [ERROR] Failed to download output blob d06295b6d31bfcc071b3a5af287c29c3ddb81d24210d7e997121d1fd87489014: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22717:140593035472512] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.306+0200 [22717:140593035472512] [executioncontext.cpp:739] [ERROR] Failed to download output blob 2253a3e6a615088a762519f189056d745d2403335cb7bddf6b3b4c4d1c18d5d4: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22971:140506068897408] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.306+0200 [22971:140506068897408] [executioncontext.cpp:739] [ERROR] Failed to download output blob 3443fcc2196ca1c83ed074c68207f33504df5049a126af60a42fe167174dcb7a: 14: Socket closed
2026-06-13T22:46:19.305+0200 [23015:139719837691520] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.306+0200 [23015:139719837691520] [executioncontext.cpp:739] [ERROR] Failed to download output blob 4cb94cac1765533f0e75bcc4c5300fde879a95b228a4d62c051ea78b17593c4f: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22851:139915004825216] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.306+0200 [22851:139915004825216] [executioncontext.cpp:739] [ERROR] Failed to download output blob b0dd2f5164efc6b0e11e94fed5252f8b40eaa943c595b131123491fee645c010: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22241:140117721640576] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.312+0200 [22241:140117721640576] [executioncontext.cpp:739] [ERROR] Failed to download output blob f963ade24e51670bd5ac46e28523866c2ec1f849c5da88b17f6e9cedfa0f5a46: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22260:140409669426816] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.314+0200 [22260:140409669426816] [executioncontext.cpp:739] [ERROR] Failed to download output blob fd3bd15188a46ca3634b753497c86c63aa65b78eea77879c61f9c2953e05dd8f: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22155:140113277136512] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.315+0200 [22155:140113277136512] [executioncontext.cpp:739] [ERROR] Failed to download output blob f923e7710969dfd54e46d53ded9976a319513aecb1b2efe6c457e5a074387db5: 14: Socket closed
2026-06-13T22:46:19.306+0200 [22354:140175052754560] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.313+0200 [22354:140175052754560] [executioncontext.cpp:739] [ERROR] Failed to download output blob 205d7542fb3d405f2e5b4ad3e19b8de9f1af088083bb8f24a81a83ce0f2ea142: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22175:140279348072064] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.315+0200 [22175:140279348072064] [executioncontext.cpp:739] [ERROR] Failed to download output blob 441b65eaf75634648b8bceac36238c0d08f98a96ee820aa33f75380848cd9e3c: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22122:140159510343296] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.316+0200 [22122:140159510343296] [executioncontext.cpp:739] [ERROR] Failed to download output blob d9b009d7c561c7f1853c200035f6b8314ce6ab0de2e38fe6b4e322be99f08adf: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22458:140005368721024] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.316+0200 [22458:140005368721024] [executioncontext.cpp:739] [ERROR] Failed to download output blob 502ce9d61956406af7395dc2f4dd725eee8ded610c9f766f13a298f8593932b4: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22500:139718183853696] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.315+0200 [22500:139718183853696] [executioncontext.cpp:739] [ERROR] Failed to download output blob c742f6a75dbe5e22495c619a6043920f1cb54a8bd8dc34e328a29b565de85180: 14: Socket closed
2026-06-13T22:46:19.305+0200 [22459:140020058189440] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-06-13T22:46:19.318+0200 [22459:140020058189440] [executioncontext.cpp:739] [ERROR] Failed to download output blob b1fa9fbc86434686c2a8beb50617ad972647db9a6fb380a8cf2f8bbc277e040a: 14: Socket closed
ninja: build stopped: subcommand failed.
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 52ab99a at 2026-06-12 21:47:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@vkucera

vkucera commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

I approve the PR as per changes in heayionMultiplicity task

Thanks @abmodak! I accidentally broke the compilation when trying to resolve a conflict, which is now fixed. Could you re-approve?

You are supposed to test every change you make.

@abmodak

abmodak commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I approve the PR as per changes in heayionMultiplicity task

Thanks @abmodak! I accidentally broke the compilation when trying to resolve a conflict, which is now fixed. Could you re-approve?

Hi @jesgum, I approve the PR as it passed all the required checks now. However, you also need approval from David to merge the PR

@abmodak abmodak enabled auto-merge (squash) June 11, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abmodak abmodak abmodak approved these changes

@ddobrigk ddobrigk ddobrigk left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner

@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

common datamodel pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jesgum @alibuild @vkucera @abmodak @ddobrigk