Repository navigation
Fix getPojavStorageRoot handling - #390
Open
thejudge156 wants to merge 2 commits into
Open
thejudge156 wants to merge 2 commits into
thejudge156 wants to merge 2 commits into
Conversation
Member
|
Did you test whether the app actually works in private dir? Afaik there are a lot of strewn across assumptions using |
Author
This only takes effect on Android >=29, I just double-checked and there aren't any references that should fire post Android 29. I did not test it, as I do not have a device that can test that. |
Author
|
Made a quick commit, just made the marker file name a constant. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android spec dictates that getExternalFilesDir can return null.
Our getPojavStorageRoot will crash relying methods if getExternalFilesDir returns null, add handling for said case.
Notes: