Repository navigation
Allow simultaneous gestures in JAR execution mode - #327
Closed
LukeAmos00 wants to merge 1 commit into
Closed
LukeAmos00 wants to merge 1 commit into
LukeAmos00 wants to merge 1 commit into
Conversation
JavaGUIViewController declares itself a UIGestureRecognizerDelegate but never implements gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:, so it silently falls back to the default (NO). This prevents holding a control button (e.g. PRI/left-click) while simultaneously dragging on the surface, since the two touches can't be recognized at the same time. SurfaceViewController already implements this and returns YES unconditionally. Mirror that same behaviour here so JAR-execution mode gets the same simultaneous-input support Minecraft sessions already have.
Taylen-chud
referenced
this pull request
in Taylen-chud/Amethyst-iOS
Sep 21, 2026
Signed-off-by: kutta <taylenwells2026@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaGUIViewController declares itself a UIGestureRecognizerDelegate but never implements gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:, so it silently falls back to the default (NO). This prevents holding a control button (e.g. PRI/left-click) while simultaneously dragging on the surface, since the two touches can't be recognized at the same time.
SurfaceViewController already implements this and returns YES unconditionally. Mirror that same behaviour here so JAR-execution mode gets the same simultaneous-input support Minecraft sessions already have.
(Marking as draft while I wait for CI to build this so I can verify it on-device before requesting review.)