chore: Update supported languages list#162
Conversation
|
The PR metadata does not comply with the established Git Commit Guidelines for AI agents: the PR title is missing the mandatory [LLM] prefix, the description is missing the required 'What' and 'Why' sections, the agent's name is missing at the end, and there is no issue number reference. |
anysoftkeyboard-bot
left a comment
anysoftkeyboard-bot
left a comment
There was a problem hiding this comment.
The data update is a straightforward refresh of Wikipedia language statistics that accurately reflects the latest data without impacting logic or architecture. While there are minor metadata and localization issues, the core changes are sound and approved.
anysoftkeyboard-bot
force-pushed
the
chore/update-languages
branch
from
87d57cb to
ef417bc
Compare
anysoftkeyboard-bot
left a comment
anysoftkeyboard-bot
left a comment
There was a problem hiding this comment.
The PR violates mandatory metadata formatting guidelines for AI Agents (missing [LLM] prefix and agent name) and contains hardcoded English strings that violate the project's localization policy.
anysoftkeyboard-bot
force-pushed
the
chore/update-languages
branch
from
ef417bc to
cfe7131
Compare
anysoftkeyboard-bot
left a comment
anysoftkeyboard-bot
left a comment
There was a problem hiding this comment.
The PR fails to follow mandatory naming and description guidelines for AI Agents and violates localization policies by hardcoding language names in English in an auto-generated file.
anysoftkeyboard-bot
force-pushed
the
chore/update-languages
branch
from
cfe7131 to
1e368a9
Compare
anysoftkeyboard-bot
left a comment
anysoftkeyboard-bot
left a comment
There was a problem hiding this comment.
The PR violates AI-generated contribution guidelines regarding title and description formatting and introduces localization technical debt by hardcoding language names in English in a generated file.
Detailed Inline Feedback (Fallback)
- app/src/main/java/com/anysoftkeyboard/janus/app/util/SupportedLanguages.kt (15-2782): The 'name' field for each SupportedLanguage is hardcoded in English, violating the project's localization policy. These should be resolved dynamically (e.g., using Locale(code).getDisplayName()) or managed via string resources. Since this file is generated, the fix should be implemented in scripts/update_languages.py to prevent recurring technical debt.
- scripts/update_languages.py (113): The comment states that the languages are sorted 'alphabetical by code', but the implementation on line 128 actually sorts by 'name'. The comment should be updated to reflect the actual sorting logic.
anysoftkeyboard-bot
force-pushed
the
chore/update-languages
branch
from
1e368a9 to
649ef9c
Compare
anysoftkeyboard-bot
force-pushed
the
chore/update-languages
branch
from
649ef9c to
2b20988
Compare
anysoftkeyboard-bot
left a comment
anysoftkeyboard-bot
left a comment
There was a problem hiding this comment.
The review was rejected due to non-compliance with established Git Commit Guidelines for AI agents, specifically regarding PR metadata (missing prefix, description sections, agent name, and issue reference).
| SupportedLanguage( | ||
| code = "isv", | ||
| name = "Interslavic", | ||
| localName = "medžuslovjansky", |
There was a problem hiding this comment.
The newly added language Interslavic (isv) is listed with activeUserCount = 0. Confirm if this is a data collection artifact or if the wiki truly had zero active contributors.
| localName = "मगही", | ||
| articleCount = 3645, | ||
| pageCount = 16490, | ||
| activeUserCount = 0, |
There was a problem hiding this comment.
The newly added language Magahi (mag) is listed with activeUserCount = 0. Confirm if this is a data collection artifact or if the wiki truly had zero active contributors.
| activeUserCount = 388, | ||
| ), | ||
| SupportedLanguage( |
There was a problem hiding this comment.
The article count for Urdu (ur) shows a significant jump from ~450k to ~643k. Ensure the source data for this specific update was verified.
2 participants
This PR updates the list of supported Wikipedia languages based on the latest statistics.