Repository navigation
only clean query parameters #2475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2cd3eec
only clean query parameters
cebtenzzre 31528b4
using urlib for making http endpoints, fixes delete endpoint
jsl12 c9011b3
added to history
jsl12 8bd112e
fix HASS url building
cebtenzzre 5adb317
Merge branch 'dev' into pr/cebtenzzre/2475
jsl12 95ef73f
use yarl.URL and handle automatic trailing slash
cebtenzzre fa42e4a
fix PydanticSchemaGenerationError
cebtenzzre ae5f6fa
just use a property
cebtenzzre 3828ece
avoid urljoin
cebtenzzre 881f348
simplify
cebtenzzre 9c4dad4
keeping the native yarl.URL object with arbitrary_types_allowed
jsl12 f680f7c
Merge branch 'pr/cebtenzzre/2485' into pr/cebtenzzre/2475
jsl12 dbaa496
pruned make_endpoint
jsl12 f573f4d
pruned unused imports
jsl12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this breaks base URLs with a path (e.g.
http://supervisor/core) - it will replace/corewith the endpoint path instead of appending. See #2485 for a better fix using yarl.