GCS_MAVLink: remove restriction on accepting RC_CHANNELS_OVERRIDE from my-gcs

[peterbarker]

this has always caused confusion. I think it might even predate the sysid-enforce stuff which is a superset of this

[tridge]

I'd be happy with this change if it was enabled with a MAV_OPTIONS bit

[joshanne]

This is quite a big change for the user. We have used MANUAL_CONTROL targetted from one ground station, while another ground station capable of control is present and communicating with a vehicle.

Removing this would result in the vehicle receiving and processing both ground stations control messages, requiring a user to enable SYSID Enforcement, which removes some level of control from the second ground station.

[peterbarker]

This is quite a big change for the user. We have used MANUAL_CONTROL targetted from one ground station, while another ground station capable of control is present and communicating with a vehicle.

Removing this would result in the vehicle receiving and processing both ground stations control messages, requiring a user to enable SYSID Enforcement, which removes some level of control from the second ground station.

Ah.... tridge theorised your scenario if I understand it correctly, thus asking for an option bit to gate it. Both of your GCSs are sending the MANUAL_CONTROL messages, then?

I'm kind of hesitant to add this behind an option bit. I think we're missing something here; tridge recently allowed us to have a range of GCSs which can be considered "mygcs" - but in your situation you couldn't use that feature as then we would accept MANUAL_CONTROL from both/all your GCSs. Further, since your GCSs are always sending the messages(?) we couldn't just "lock on" to the one we want to have control.

Discussion is over here #29252