Skip to content

chore(js): upgrade Changesets publishing - #15718

Merged
mikeldking merged 1 commit into
mainfrom
codex/upgrade-changesets-v3
Aug 29, 2026
Merged

mikeldking merged 1 commit into
mainfrom
codex/upgrade-changesets-v3

Conversation

@mikeldking

Copy link
Copy Markdown
Collaborator

Summary

  • upgrade @changesets/cli to v3.0.1 and the config schema to v4
  • migrate the publishing workflow to changesets/action v2.1.1 using its renamed inputs
  • pass the custom GitHub token explicitly and use the restored monorepo cwd support

Testing

  • CI=true pnpm --dir js install --frozen-lockfile
  • cd js && node_modules/.bin/changeset status --since HEAD
  • parsed .github/workflows/typescript-packages-publish.yml as YAML
  • git diff --check

No changeset is included because this only updates development tooling and the publishing workflow.

@mikeldking
mikeldking requested a review from a team as a code owner August 28, 2026 18:27
@github-project-automation github-project-automation Bot moved this to 📘 Todo in phoenix Aug 28, 2026
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 28, 2026
@pkg-pr-new

pkg-pr-new Bot commented Aug 28, 2026

Copy link
Copy Markdown

Open in StackBlitz

@arizeai/phoenix-cli

npm i https://pkg.pr.new/@arizeai/phoenix-cli@15718

@arizeai/phoenix-client

npm i https://pkg.pr.new/@arizeai/phoenix-client@15718

@arizeai/phoenix-config

npm i https://pkg.pr.new/@arizeai/phoenix-config@15718

@arizeai/phoenix-evals

npm i https://pkg.pr.new/@arizeai/phoenix-evals@15718

@arizeai/phoenix-mcp

npm i https://pkg.pr.new/@arizeai/phoenix-mcp@15718

@arizeai/phoenix-otel

npm i https://pkg.pr.new/@arizeai/phoenix-otel@15718

commit: 72d5a8e

@mintlify

mintlify Bot commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
arize-phoenix 🟢 Ready View Preview Aug 28, 2026, 6:33 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

# Pinned to v1.5.2 because released versions after that still break monorepo
# cwd handling; the upstream fix merged after v1.7.0 but is not released yet.
uses: changesets/action@d183df40791e90508058cd180e6435cdd9ba16a4 # v1.5.2
uses: changesets/action@8488615a623b1b9c987934bb89eae8af6a946ac1 # v2.1.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pinned SHA does not exist in changesets/action, so this step will fail to resolve.

8488615a623b1b9c987934bb89eae8af6a946ac1 is not a commit in changesets/action (or anywhere on GitHub):

$ gh search commits --hash 8488615a623b1b9c987934bb89eae8af6a946ac1 --json sha,repository
[]

The actual v2.1.1 release commit is d7669c894a691cf0908002c33cdd57df54a1ef3b — the merge commit of changesets/action#722 ("Version Packages", body: ## @changesets/action@2.1.1), merged 2026-08-19. That SHA does resolve, confirming the search index is current and the empty result above is a genuine miss rather than an indexing gap.

uses: with an unresolvable SHA fails immediately with Unable to resolve action changesets/action@8488615…. This workflow is on: push: branches: [main], so nothing in PR CI exercises it — the first symptom would be a broken JS package release after merge.

# can trigger subsequent workflows (like publish) when merged
uses: changesets/action@8488615a623b1b9c987934bb89eae8af6a946ac1 # v2.1.1
with:

Suggested change
uses: changesets/action@8488615a623b1b9c987934bb89eae8af6a946ac1 # v2.1.1
uses: changesets/action@d7669c894a691cf0908002c33cdd57df54a1ef3b # v2.1.1

For what it's worth, the rest of the migration checks out: the renamed inputs (version-script, publish-script, commit-message, pr-title, create-github-releases), the move of the token from GITHUB_TOKEN env to the github-token input, and the relative cwd: js are all correct for v2 — and the @changesets/cli v3 bump is in fact required by v2's validateChangesetsCliVersion check.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a false positive — 8488615a623b1b9c987934bb89eae8af6a946ac1 is exactly what changesets/action@v2.1.1 resolves to.

v2.1.1 is an annotated tag, so the ref points at a tag object, not directly at the commit:

$ gh api repos/changesets/action/git/ref/tags/v2.1.1
{"ref":"refs/tags/v2.1.1","type":"tag","sha":"fdf536a68c4154480c89b42547f8102cf0d8bc47"}

$ gh api repos/changesets/action/git/tags/fdf536a68c4154480c89b42547f8102cf0d8bc47
{"tag":"v2.1.1","object":{"type":"commit","sha":"8488615a623b1b9c987934bb89eae8af6a946ac1"}}

$ gh api repos/changesets/action/commits/8488615a623b1b9c987934bb89eae8af6a946ac1
{"sha":"8488615a...","msg":"v2.1.1","date":"2026-08-19T06:36:34Z"}

The empty gh search commits --hash result is a search-index miss, not proof of absence — the commits API resolves the SHA fine.

The suggested d7669c894a691cf0908002c33cdd57df54a1ef3b is Version Packages (#722) from 2026-08-19T05:29:59Z, roughly an hour before the commit the tag actually points at. Taking the suggestion would pin a commit that v2.1.1 does not reference, so the # v2.1.1 comment would become inaccurate. Leaving the pin as-is.

@mikeldking
mikeldking merged commit c1da84b into main Aug 29, 2026
56 checks passed
@mikeldking
mikeldking deleted the codex/upgrade-changesets-v3 branch August 29, 2026 01:04
@github-project-automation github-project-automation Bot moved this from 📘 Todo to ✅ Done in phoenix Aug 29, 2026

This branch was successfully deployed

1 active deployment
staging — 72d5a8e8 Deployed Aug 28, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant