Increase renewal timeout and add Initializing-state diagnostics - #2
Open
psasidhar wants to merge 1 commit into
Open
Increase renewal timeout and add Initializing-state diagnostics#2psasidhar wants to merge 1 commit into
psasidhar wants to merge 1 commit into
Conversation
Three changes to manager/manager.go: 1. issueRenewalTimeout: 60s → 5min Gives the issuer time to stamp Initializing and ZTS time to sign before the driver times out and abandons the in-flight CertificateRequest. 2. case "Initializing" in handleRequest poll loop Tracks when Initializing is first observed, warns if it persists >1min, and logs elapsed time when the CR is eventually signed or times out. 3. Log in findPendingRequest when an existing CR is skipped as non-resumable Surfaces the one-cycle-delay scenario: if a CR is still Initializing when the retry runs, this log confirms the driver is creating a replacement CR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Sasi Palaka <palakas@yahooinc.com>
psasidhar
force-pushed
the
fix/renewal-timeout-initializing
branch
from
July 24, 2026 14:20
8ef8dfa to
41aab78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes to manager/manager.go:
issueRenewalTimeout: 60s → 5min Gives the issuer time to stamp Initializing and ZTS time to sign before the driver times out and abandons the in-flight CertificateRequest.
case "Initializing" in handleRequest poll loop Tracks when Initializing is first observed, warns if it persists >1min, and logs elapsed time when the CR is eventually signed or times out.
Log in findPendingRequest when an existing CR is skipped as non-resumable Surfaces the one-cycle-delay scenario: if a CR is still Initializing when the retry runs, this log confirms the driver is creating a replacement CR.