Notifications: gate v3 panel behind hosting-dashboard-opt-in preference#49560
Open
arthur791004 wants to merge 1 commit into
Open
Notifications: gate v3 panel behind hosting-dashboard-opt-in preference#49560arthur791004 wants to merge 1 commit into
arthur791004 wants to merge 1 commit into
Conversation
Replace the `notifications=v3` query parameter gate with the user's `calypso_preferences['hosting-dashboard-opt-in']` value, mirroring the wpcom admin-bar "All Sites" logo gate. Falls back to v2 when get_user_attribute() is unavailable (self-hosted Jetpack). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
github-actions
Bot
added
the
[Plugin] Jetpack
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes
notifications=v3query-parameter gate (added in Notifications: gate v3 panel behind a notifications=v3 query parameter #49514) with a check on the current user'scalypso_preferences['hosting-dashboard-opt-in']value. When that value is'opt-in', the notifications admin-bar item renders#wpnt-notes-panel3(v3 panel/iframe); otherwise it renders#wpnt-notes-panel2.get_user_attribute()withfunction_exists()so self-hosted Jetpack sites (where the function and the preference don't exist) safely fall back to the v2 panel.Related product discussion/links
Does this pull request change what data or activity we track or use?
No. It reads an existing user preference (
calypso_preferences) to decide which notifications panel markup to render.Testing instructions
get_user_attribute()andcalypso_preferencesare available):#wpnt-notes-panel2.calypso_preferences['hosting-dashboard-opt-in']['value']toopt-in, reload, and confirm the panel div is now#wpnt-notes-panel3and clicking the bell opens the v3 panel (iframehttps://widgets.wp.com/notifications/app/) in a browser that allows third-party cookies.#wpnt-notes-panel2and is unaffected.