Write: use progress cursor on Save buttons while saving#49566
Write: use progress cursor on Save buttons while saving#49566allilevine wants to merge 1 commit into
Conversation
The Save Draft and Publish buttons are briefly disabled while a save is in flight (via state.isSaving), and .bw-btn:disabled was applying cursor: not-allowed. That's the wrong affordance: the action is succeeding, just in progress — matching the existing .bw-uploading pattern, we now use cursor: progress for the in-flight state.
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Fixes RSM-4006
Proposed changes
disabled(viadata-wp-bind--disabled="state.isSaving"). The shared.bw-btn:disabledrule was applyingcursor: not-allowed, which is the affordance for "this action is forbidden" — wrong for an in-flight save that is actually succeeding. Switched tocursor: progressto match the existing.bw-upload-zone.bw-uploadingprecedent.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
/writeon a WP.com site running this build).Note: the in-flight window is brief — easiest to observe on a slow network (devtools → Network → Slow 3G) or on a longer post.