git: provide version control and HTTP transport - #19
Conversation
0c97e68 to
f83dd30
Compare
|
Independent devil's-advocate review completed against original head Review findings fixed in the tap:
Exact final source build and literal Homebrew test pass. Ruby syntax, style, strict online audit, Do not merge yet. The full upstream |
cbdfc94 to
892ed65
Compare
b7f4ed8 to
e8c3f61
Compare
892ed65 to
7559e56
Compare
|
Devil's-advocate audit found and fixed a masked compiled-path bug in
The Formula now passes the stable guest This review does not claim a fresh source build, bottle, stock-Homebrew pour, Node run, or Chromium run for the changed head; those remain explicit platform and publisher gates in the PR body. |
700c1f6 to
d14bdf4
Compare
d14bdf4 to
9894df9
Compare
Kandelo users and package builds need real Git workflows from Homebrew instead of registry artifacts or reduced wrappers. Git must exercise its normal helper, shell, pager, editor, template, clone, and network paths so platform gaps remain visible. Build Git 2.47.1 through the Kandelo SDK, install its reviewed runtime and documentation surface, declare the complete target dependency closure, instrument every linked Wasm program, and test repository, child-process, editor, pager, clone, and HTTPS behavior.
9894df9 to
4eee208
Compare
Why
Kandelo users and package builds need real Git workflows from Homebrew instead of Kandelo registry archives or a reduced wrapper. Git is both a user tool and infrastructure for development workflows, so the Formula must exercise its normal helper programs, shell, pager, editor, templates, cloning, and network transport. Hiding any of those paths would hide platform failures.
All required source Formulae are now on the default tap, including Vim. This PR can therefore land as source while bottle publication continues dependency-first.
What changed
git, upload/receive aliases, HTTP/HTTPS/FTP remote helpers, envsubst, the supported shell commands and libraries, mergetool resources, templates, and the matching upstream manpages.opt/gitpaths, then test those compiled paths without overridingGIT_EXEC_PATHorGIT_TEMPLATE_DIR.The original nine feature/fixup commits are folded into one purpose-led commit. Subsequent review fixups make the two
skip_cleanhelper paths literal, declare exact helper-process counts, and satisfy the pinned Homebrew style rules. These fixups do not change package output behavior; the process counts strengthen test completion evidence.This PR contains no bottle block, archive, sidecar, receipt, generated Wasm artifact, platform change, or Kandelo ABI change.
Exact source state
ed5dfe7d0cacc5209e325351e480809221b0cafa4eee208f8d595d2049c657fe548daf9a778a7ebf5419da213a1c6a3a02124982d5c9fa1814a1fd7d3ceb132696322776fc17255dbd3ad416b7b05c25171bb610c560d6fc01c89e5658a3312138858f50d0b922f9602cbecff6b366809c454762625d2e4f5cf44e802f7c37ab1526e18dThe branch now rests on merged PTY descendant support. The final Formula change declares the audited helper counts for Less pagination (1), mergetool discovery (4), and Vim editing (1), so those interactive tests cannot pass while helpers are still running.
Evidence
Fresh checks on this exact head passed:
Formula/git.rb34c40c18ffa2029b611b61c73273e32c003d0842scripts/dev-shell.shgit diff --checkThe fresh source-closure check reverified the exact Git source archive SHA-256
f3d8f9bb23ae392374e91cd9d395970dabc5b9c5ee72f39884613cd84a6ed310, the exact matching manpage archive SHA-256ffc2005a89b056c0727b667f6beda0068371619762ea4844ad0229091befee13, required source and manpage members, and clean application of the embedded patch. Earlier audits also verified safe archive members and the delivered source licenses.Fresh exact-head self/devil review accepted the Formula semantics, dependency closure, source and patch provenance, helper counts, scope, and Brandon Payton attribution. No current ABI 41 Git source build, Formula run, bottle, stock Homebrew pour, Node.js run, Chromium run, or in-guest install is claimed here.
Platform and publication gates
The POSIX, SDK, continuation-capacity, process, and publisher changes that blocked the old ABI 39 branch are now in merged ABI 41 Kandelo. That removes the source-merge blocker; the trusted publisher must still build this exact merged Formula and prove the mergetool, editor, clone, and HTTPS tests on ABI 41.
All thirteen Formulae in Git's full source closure are on tap
main. Their ABI 41 bottles are not all published yet. Publication must consume public dependency bottles through the normal Homebrew path and must not fall back to Kandelo registry archives or ambient source builds.The current critical path remains the four pilot bottles, then the Libmagic/File VFS closure. Git is a later leaf package. When its dependency bottles are ready, Git must pass public GHCR readback, stock Homebrew pour, and its real installed workflows before it is used as migration evidence.