This repository was archived by the owner on Jul 21, 2026. It is now read-only.
zstd: add threaded compression library and tools - #27
Merged
Conversation
Member
Author
|
Devil's-advocate review on final head Two blockers were corrected:
I also enlarged both threaded workloads. The C path now uses two workers across multiple 1 MiB jobs, rather than merely accepting No formula-code blocker remains. This is not merge approval until #842, #867/ABI-18 artifacts, #884, and trusted final-head bottle pour/test gates are real. |
brandonpayton
force-pushed
the
migrate/zstd-dependency-root
branch
from
July 11, 2026 23:10
c3bb768 to
f0f32e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Replace the registry-only zstd program with a source-built Homebrew dependency root that exposes both the compression CLI and a complete static-library consumer contract.
Changes
optpkg-config metadata, the zstd CLI aliases, and the zstd manpage;zstdgrepandzstdlessshell helpers because they would invert the dependency wave by requiring the leaf grep and less packages;Evidence
Using a dedicated Homebrew prefix and ABI-18 Kandelo integration runtime:
brew test automattic/kandelo-homebrew/zstdpassed under Node;-T2and validates the unzstd/zstdcat aliases;optprefix throughlibzstd.pc, verifies-lzstdand-pthread, and round-trips 2 MiB as multiple 1 MiB jobs with two workers;ruby -c,brew style,brew audit --strict --online, andgit diff --checkpassed;An independent devil's-advocate pass found and corrected the undeclared helper-script dependencies and the prior test's manual
-I/-Lbypass of the published pkg-config contract. No formula-code blocker remains. The artifact-producing commits were rebased semantic-preservingly onto tap main ata4c52a1; commit95250d1changes only shared-support loading to the installedTap.fetchpath.Source merge and bottle gates
The source formula may merge independently after a fresh formula review; it contains no bottle block or sidecar. Bottle construction, publication, and any installability claim remain gated until:
95250d1and pass sidecar generation, stock guest pour, CLI tests, and a poured-bottle library consumer;The pthread fork-continuation fix and ABI 18 transition from #867 are merged.
Post-rebase validation through
scripts/dev-shell.sh: Homebrew Ruby syntax passed, the current support suite passed 21 runs/186 assertions,brew stylereported no offenses, andgit diff --checkpassed. At95250d1, syntax, style, literal loading throughTap.fetch, the support suite (21 runs/186 assertions), andgit diff --checkpassed. Functional source-build evidence remains tied to unchanged artifact logic; no bottle is claimed.This wave intentionally publishes wasm32 only. Firefox, WebKit, and wasm64 were not validated and are not claimed here. No Kandelo ABI or main-repository files change in this PR.