This repository was archived by the owner on Jul 21, 2026. It is now read-only.
ed: add the conforming line editor dependency - #31
Merged
Conversation
brandonpayton
force-pushed
the
migrate/ed-cli
branch
from
July 11, 2026 23:25
b74e858 to
6c6c82f
Compare
brandonpayton
force-pushed
the
migrate/ed-cli
branch
from
July 12, 2026 01:23
6c6c82f to
6d75f43
Compare
Member
Author
|
Devil’s-advocate source-only review at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Publish GNU ed as a first-class Kandelo package so patch application and other POSIX build workflows have a conforming line editor instead of the deliberately small posix-utils-lite applet.
Changes
lzipas a host-only extraction dependency and avoid introducing a targetseddependency;fork;ed, a relocatable POSIX-shellredwrapper, manpages, and Info documentation;ed - FILEinvocation shape, editing commands, shell execution, and restricted mode.The
redwrapper replaces upstream's sed-based path rewrite with equivalent POSIX parameter expansion. This avoids an undeclared targetsedruntime dependency and leaves/bin/shas the normal Kandelo base-system boundary.Evidence
The formula semantics are unchanged from the previously reviewed ABI-18 build:
b74e858;brew test automattic/kandelo-homebrew/edpassed under Node;ed - FILEform, and restricted shell rejection;edandredpassed the same process-path workflow in Chromium;env/kernelimports, all fivewpk_fork_*exports, no legacy Asyncify, and no Cellar or host paths.The three-commit branch is now based on tap main
e05afec, which includes Dash, zstd, PCRE2, and Make. Every artifact-producing formula line after the support import is byte-identical to the validated6c6c82fhead; the final commit changes only loading to the installedTap.fetchpath. Current head is6d75f4342c3791318795c333db09013c663b2a05.Current rebase validation through Kandelo's dev shell passed Homebrew Ruby syntax,
brew style, literal installed-tap loading,git diff --check, and the shared Formula support suite (21 runs, 186 assertions). The formula tail matches the validated head exactly; no source build or runtime suite was rerun for this history-only rebase.Upstream
make checkwas not run because its host shell executes the cross-compiled editor directly. The Node and Chromium formula workflows instead exercised the target program through Kandelo.The prior disposable bottle SHA-256
9a5043665b32f4fe38ca9301bd3799329b853199ca1cdacbbbe15b2f26cc87f6is historical validation only. It is rejected for publication after the rebase and platform changes and must not be copied into a bottle block.Source merge and bottle gates
Automattic/kandelo#867 is merged and is no longer a gate. The source formula may merge independently after a fresh formula review; it contains no bottle block or sidecar. Bottle construction, publication, and any installability claim remain gated until:
This PR publishes wasm32 only. Firefox, WebKit, and wasm64 were not validated and are not claimed. No Kandelo main-repository files or ABI definitions change here.