-
Notifications
You must be signed in to change notification settings - Fork 614
fix(aztec-nr): reject zero delays in DelayedPublicMutable #25104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vezenovm
wants to merge
15
commits into
merge-train/fairies
Choose a base branch
from
mv/f-840-nonzero-delay
base: merge-train/fairies
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5e27080
fix: reject zero delays in DelayedPublicMutable
vezenovm 7eed79a
fix: reject a zero initial delay when declaring a DelayedPublicMutable
vezenovm 1a16744
test: tighten the effective-minimum-delay invariant and drop the zero…
vezenovm 5f2f94a
test: drop the redundant minimum-delay test and the invariant helper …
vezenovm 0cce33f
docs: explain the zero-delay rule where delay selection is discussed
vezenovm 1020773
refactor: drop the redundant compile-time guard in ScheduledDelayChange
vezenovm 8e7be2c
Merge branch 'merge-train/fairies' into mv/f-840-nonzero-delay
vezenovm 80b96ef
Merge branch 'merge-train/fairies' into mv/f-840-nonzero-delay
vezenovm 4c7d3bf
fix: reject a zero initial delay on every delay read path
vezenovm bf727d5
docs: note both zero-delay guards on ScheduledDelayChange
vezenovm 963548d
Apply suggestion from @vezenovm
vezenovm 7e98006
docs: expand delay selection guidance for DelayedPublicMutable
vezenovm f40ddca
Merge remote-tracking branch 'origin/mv/f-840-nonzero-delay' into mv/…
vezenovm 439c594
Merge branch 'merge-train/fairies' into mv/f-840-nonzero-delay
vezenovm 0da9ef6
Apply suggestion from @vezenovm
vezenovm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point re. disallowing zero, but I think this is the key part. We force users to do this or have a hidden escalation of privileges: I'd rather we had an e.g. 1 hour minimum so that this risk is massively diminished.