Skip to content

fix(bbup): accept v-prefixed versions - #25287

Open
loglapa wants to merge 1 commit into
AztecProtocol:nextfrom
loglapa:fix/17107-bbup-v-prefix
Open

fix(bbup): accept v-prefixed versions#25287
loglapa wants to merge 1 commit into
AztecProtocol:nextfrom
loglapa:fix/17107-bbup-v-prefix

Conversation

@loglapa

@loglapa loglapa commented Aug 21, 2026

Copy link
Copy Markdown

Closes #17107.

Summary

Allow bbup -v to accept release versions with or without a leading v. bbup owns release-tag construction and now strips one optional user-supplied prefix before version comparison and URL generation, preventing tags such as vv0.77.1.

Add the prefixed form to the existing real-install test matrix and normalize its expected bb --version value. Existing unprefixed and shell-config behavior remains covered.

Testing

Run in the repository aztecprotocol/build:3.0 ARM64 container:

  • barretenberg/bbup/run_test.sh install v0.77.1
  • barretenberg/bbup/run_test.sh install 0.77.1
  • barretenberg/bbup/run_test.sh shell_config 0.77.1

Additional checks:

  • bash -n on all three changed scripts
  • official ShellCheck container with --severity=error (the files retain pre-existing lower-severity findings)

@loglapa
loglapa marked this pull request as ready for review August 23, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bbup does not allow v-prefixes on tags despite release tags all being prefixed

1 participant