Skip to content

fix(iframe-app): harden Frame Blade auth-token handling (CodeQL js/user-controlled-bypass) #9372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rllyy97 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(iframe-app): harden Frame Blade auth-token handling (CodeQL js/user-controlled-bypass) #9372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
058dc57
fix(iframe-app): harden Frame Blade auth-token handling (CodeQL js/us…
rllyy97 Jul 7, 2026
89c2975
docs(iframe-app): clarify auth-token guard rationale in comment
rllyy97 Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions apps/iframe-app/src/lib/hooks/useFrameBlade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,21 @@ export function useFrameBlade({
}
break;

case 'authToken':
if (msg.data && onAuthTokenReceived) {
onAuthTokenReceived(msg.data);
case 'authToken': {
// The trust decision has already been made above: messages are only
// processed if they come from the allow-list-validated
// trustedParentOrigin (evt.origin check) and carry the FxFrameBlade
// signature. This block adds payload validation - the token must be a
// non-empty string and a handler must be present - expressed as an
// early-return guard clause. The guard-clause shape (validate, then
// return early) is also what CodeQL's ConditionalBypass query treats
// as a safe early-abort guard rather than a user-controlled bypass.
if (!onAuthTokenReceived || typeof msg.data !== 'string' || msg.data.length === 0) {
return;
}
onAuthTokenReceived(msg.data);
break;
}

case 'chatHistory':
// Handle chat history data from parent blade
Expand Down
Loading