refactor(vscode): Refactor designer/monitoring view/connection view classes#9397
Open
andrew-eldridge wants to merge 13 commits into
Open
refactor(vscode): Refactor designer/monitoring view/connection view classes#9397andrew-eldridge wants to merge 13 commits into
andrew-eldridge wants to merge 13 commits into
Conversation
…delessTestCleanup
…delessTestCleanup
…ds, fix type errors
andrew-eldridge
added
risk:low
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
✅ Contributors
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | No change needed |
| Commit Type | ✅ | No change needed |
| Risk Level | ✅ | Medium is correct; fix "Low risk" wording in body |
| What & Why | ✅ | Optional wording fix |
| Impact of Change | ✅ | No change needed |
| Test Plan | ✅ | No change needed |
| Contributors | ✅ | No change needed |
| Screenshots/Videos | Not required (non-visual) |
All required checks pass — this PR is compliant and cleared to merge. Consider aligning the "Low risk" note with the selected Medium level.
Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Thu, 16 Jul 2026 18:50:39 GMT
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the VS Code extension’s designer/monitoring/connection view panel architecture toward a more consistent “panel class” pattern (to align with upcoming V2 panel work), while also removing unit-test-related UI/state/models across the designer, designer-v2, designer-ui, and VS Code webview apps.
Changes:
- Refactors VS Code extension panel entrypoints (designer + monitoring + connection view) to use new panel classes and updated command wiring.
- Renames exported panel metadata type (
IDesignerPanelMetadata→DesignerPanelMetadata) and adds new supporting models (ConnectionPanelMetadata,CodeSelection). - Removes unit test view functionality (assertions/mock results/unit-test webviews/state) across multiple packages.
Reviewed changes
Copilot reviewed 178 out of 178 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/vscode-extension/src/lib/models/workflow.ts | Renames and standardizes panel metadata model to DesignerPanelMetadata. |
| libs/vscode-extension/src/lib/models/unitTest.ts | Removes VS Code extension unit test result models. |
| libs/vscode-extension/src/lib/models/project.ts | Removes unitTest project/route entries. |
| libs/vscode-extension/src/lib/models/index.ts | Stops exporting unit test models; exports new codeful models. |
| libs/vscode-extension/src/lib/models/extensioncommand.ts | Removes saveUnitTest command constant. |
| libs/vscode-extension/src/lib/models/connection.ts | Adds ConnectionPanelMetadata contract for connection view panel initialization. |
| libs/vscode-extension/src/lib/models/codeful.ts | Introduces CodeSelection type used for codeful insertion context. |
| libs/logic-apps-shared/src/utils/src/lib/models/unitTest.ts | Removes shared unit test definition-related models. |
| libs/logic-apps-shared/src/utils/src/lib/models/index.ts | Stops exporting unit test models from shared utils. |
| libs/logic-apps-shared/CLAUDE.md | Removes unit-test-specific error handling import guidance. |
| libs/designer/src/lib/ui/panel/panelRoot.tsx | Removes Assertions panel rendering path and adjusts blocking behavior. |
| libs/designer/src/lib/ui/panel/nodeDetailsPanel/usePanelTabs.tsx | Removes unit test-only mock results tab logic. |
| libs/designer/src/lib/ui/panel/nodeDetailsPanel/tabs/mockResultsTab/mockResultsTab.tsx | Deletes mock results tab implementation. |
| libs/designer/src/lib/ui/panel/nodeDetailsPanel/tabs/mockResultsTab/helper.ts | Deletes mock results output filtering helper. |
| libs/designer/src/lib/ui/panel/nodeDetailsPanel/test/usePanelTabs.spec.ts | Updates tests to remove unit test tab expectations. |
| libs/designer/src/lib/ui/CustomNodes/OperationCardNode.tsx | Removes unit test mock status props/wiring from node cards. |
| libs/designer/src/lib/core/store.ts | Removes unitTest slice from designer Redux store. |
| libs/designer/src/lib/core/state/unitTest/unitTestSelectors.ts | Deletes unit test selectors/hooks. |
| libs/designer/src/lib/core/state/unitTest/unitTestInterfaces.ts | Deletes unit test state interfaces. |
| libs/designer/src/lib/core/state/panel/panelTypes.ts | Removes Assertions panel mode/type from panel state types. |
| libs/designer/src/lib/core/state/designerOptions/designerOptionsSlice.ts | Removes isUnitTest option from designer options state initialization. |
| libs/designer/src/lib/core/state/designerOptions/designerOptionsSelectors.ts | Removes useUnitTest selector. |
| libs/designer/src/lib/core/state/designerOptions/designerOptionsInterfaces.ts | Removes isUnitTest option from designer options interface. |
| libs/designer/src/lib/core/index.ts | Removes unit-test serialization + unit-test selector exports. |
| libs/designer/src/lib/core/BJSWorkflowProvider.tsx | Removes unit test definition initialization in provider. |
| libs/designer/src/lib/core/actions/bjsworkflow/serializer.ts | Removes unit test definition serialization and related helpers. |
| libs/designer/src/lib/common/constants.ts | Removes MOCK_RESULTS tab constant. |
| libs/designer/src/lib/test/redux-test-helper.tsx | Removes unit test slice from test store helper. |
| libs/designer-v2/src/lib/ui/panel/panelRoot.tsx | Removes Assertions panel path from v2 panel root. |
| libs/designer-v2/src/lib/ui/panel/nodeDetailsPanel/usePanelTabs.tsx | Removes unit test-only mock results tab logic (v2). |
| libs/designer-v2/src/lib/ui/panel/nodeDetailsPanel/tabs/mockResultsTab/mockResultsTab.tsx | Deletes mock results tab implementation (v2). |
| libs/designer-v2/src/lib/ui/panel/nodeDetailsPanel/tabs/mockResultsTab/helper.ts | Deletes mock results helper (v2). |
| libs/designer-v2/src/lib/ui/panel/nodeDetailsPanel/tests/usePanelTabs.spec.tsx | Updates v2 tests to remove unit test tab expectations. |
| libs/designer-v2/src/lib/ui/panel/test/panelRoot.spec.tsx | Updates v2 panel root tests to remove Assertions panel coverage. |
| libs/designer-v2/src/lib/ui/CustomNodes/OperationCardNode.tsx | Removes unit test mock status props/wiring from v2 node cards. |
| libs/designer-v2/src/lib/ui/CustomNodes/components/card/actionCard.tsx | Removes unit-test-only props/usages from v2 action card. |
| libs/designer-v2/src/lib/ui/CustomNodes/test/OperationCardNode.spec.tsx | Updates v2 node tests to remove unit test hook mocking. |
| libs/designer-v2/src/lib/core/store.ts | Removes unitTest slice from v2 Redux store. |
| libs/designer-v2/src/lib/core/state/unitTest/unitTestSelectors.ts | Deletes v2 unit test selectors/hooks. |
| libs/designer-v2/src/lib/core/state/unitTest/unitTestInterfaces.ts | Deletes v2 unit test state interfaces. |
| libs/designer-v2/src/lib/core/state/panel/panelTypes.ts | Removes Assertions panel mode/type from v2 panel state types. |
| libs/designer-v2/src/lib/core/state/designerOptions/designerOptionsSlice.ts | Removes isUnitTest from v2 designer options state. |
| libs/designer-v2/src/lib/core/state/designerOptions/designerOptionsSelectors.ts | Removes useUnitTest selector (v2). |
| libs/designer-v2/src/lib/core/state/designerOptions/designerOptionsInterfaces.ts | Removes isUnitTest option (v2). |
| libs/designer-v2/src/lib/core/index.ts | Removes unit-test serialization + selector exports (v2). |
| libs/designer-v2/src/lib/core/BJSWorkflowProvider.tsx | Removes unit test definition initialization (v2 provider). |
| libs/designer-v2/src/lib/core/actions/bjsworkflow/serializer.ts | Removes unit test serialization and helpers (v2). |
| libs/designer-v2/src/lib/common/constants.ts | Removes MOCK_RESULTS constant (v2). |
| libs/designer-v2/src/lib/test/redux-test-helper.tsx | Removes unit test slice from v2 test store helper. |
| libs/designer-ui/src/lib/unitTesting/outputMocks/outputMocks.tsx | Deletes unit testing OutputMocks component. |
| libs/designer-ui/src/lib/unitTesting/outputMocks/outputMocks.styles.ts | Deletes OutputMocks styles. |
| libs/designer-ui/src/lib/unitTesting/outputMocks/outputMocks.less | Deletes OutputMocks LESS. |
| libs/designer-ui/src/lib/unitTesting/outputMocks/ouputsSettings.tsx | Deletes outputs settings component for OutputMocks. |
| libs/designer-ui/src/lib/unitTesting/outputMocks/index.tsx | Stops exporting OutputMocks. |
| libs/designer-ui/src/lib/unitTesting/outputMocks/errorDetails.tsx | Deletes unit test error details UI. |
| libs/designer-ui/src/lib/unitTesting/outputMocks/actionResult.tsx | Deletes action result UI for unit test mocks. |
| libs/designer-ui/src/lib/unitTesting/mockStatusIcon/mockStatusIcon.styles.ts | Deletes mock status icon styles. |
| libs/designer-ui/src/lib/unitTesting/mockStatusIcon/mockStatusIcon.less | Deletes mock status icon LESS. |
| libs/designer-ui/src/lib/unitTesting/mockStatusIcon/index.tsx | Deletes mock status icon component. |
| libs/designer-ui/src/lib/unitTesting/mockStatusIcon/empty.tsx | Deletes empty status icon implementation. |
| libs/designer-ui/src/lib/unitTesting/mockStatusIcon/completed.tsx | Deletes completed status icon implementation. |
| libs/designer-ui/src/lib/unitTesting/mockStatusIcon/tests/mockStatusIcon.spec.tsx | Deletes mock status icon tests. |
| libs/designer-ui/src/lib/unitTesting/mockStatusIcon/tests/snapshots/mockStatusIcon.spec.tsx.snap | Deletes mock status icon snapshots. |
| libs/designer-ui/src/lib/unitTesting/conditionExpression/conditionExpression.styles.ts | Deletes condition expression styles. |
| libs/designer-ui/src/lib/unitTesting/conditionExpression/conditionExpression.less | Deletes condition expression LESS. |
| libs/designer-ui/src/lib/unitTesting/conditionExpression/tests/conditionExpression.spec.tsx | Deletes condition expression tests. |
| libs/designer-ui/src/lib/unitTesting/conditionExpression/tests/snapshots/conditionExpression.spec.tsx.snap | Deletes condition expression snapshots. |
| libs/designer-ui/src/lib/unitTesting/assertionsPanel/index.ts | Deletes assertions panel exports. |
| libs/designer-ui/src/lib/unitTesting/assertionsPanel/assertions.tsx | Deletes assertions panel UI. |
| libs/designer-ui/src/lib/unitTesting/assertionsPanel/assertions.less | Deletes assertions panel LESS. |
| libs/designer-ui/src/lib/unitTesting/assertionsPanel/assertionField.tsx | Deletes assertion field UI. |
| libs/designer-ui/src/lib/unitTesting/assertionsPanel/assertionButtons.tsx | Deletes assertion buttons UI. |
| libs/designer-ui/src/lib/unitTesting/assertionsPanel/assertion.tsx | Deletes assertion item UI. |
| libs/designer-ui/src/lib/unitTesting/assertionsPanel/tests/assertions.spec.tsx | Deletes assertions panel tests. |
| libs/designer-ui/src/lib/unitTesting/assertionsPanel/tests/assertion.spec.tsx | Deletes assertion tests. |
| libs/designer-ui/src/lib/unitTesting/assertionsPanel/tests/snapshots/assertions.spec.tsx.snap | Deletes assertion snapshots. |
| libs/designer-ui/src/lib/styles.less | Removes unitTesting LESS imports from global styles. |
| libs/designer-ui/src/lib/overview/runhistory.tsx | Removes unit-test support prop from run history contract. |
| libs/designer-ui/src/lib/overview/index.tsx | Removes unit-test support prop plumbing in overview component. |
| libs/designer-ui/src/lib/index.ts | Stops exporting unit testing components. |
| libs/designer-ui/src/lib/card/index.tsx | Removes unit-test mock status icon from card rendering and props. |
| LESS_FILES_MIGRATION_ANALYSIS.md | Removes unit testing LESS entries from migration analysis. |
| docs/plans/2025-01-14-monaco-to-codemirror-implementation.md | Removes a unit-testing task section from the plan doc. |
| docs/plans/2025-01-14-monaco-to-codemirror-design.md | Removes unitTesting mention from migration design doc. |
| docs/ai-setup/packages/logic-apps-shared.md | Removes unit-test error handling import guidance. |
| apps/vs-code-react/src/stateWrapper.tsx | Removes navigation handling for unitTest project. |
| apps/vs-code-react/src/state/WorkflowSlice.ts | Removes supportsUnitTest from workflow state. |
| apps/vs-code-react/src/state/UnitTestSlice.ts | Deletes UnitTest Redux slice for the webview app. |
| apps/vs-code-react/src/state/store.ts | Removes unitTest reducer registration. |
| apps/vs-code-react/src/state/LanguageServerSlice.ts | Updates metadata type name to DesignerPanelMetadata. |
| apps/vs-code-react/src/state/DesignerSlice.ts | Removes unit test state/definition wiring; updates metadata type name. |
| apps/vs-code-react/src/run-service/types.ts | Updates message contract to DesignerPanelMetadata. |
| apps/vs-code-react/src/router/index.tsx | Removes unit test route/view. |
| apps/vs-code-react/src/intl/messages.ts | Removes unit-test-specific message definitions and related designer strings. |
| apps/vs-code-react/src/intl/index.ts | Stops exporting unitTestMessages. |
| apps/vs-code-react/src/app/unitTest/unitTestStyles.ts | Deletes unit test results view styles. |
| apps/vs-code-react/src/app/unitTest/index.tsx | Deletes unit test results view implementation. |
| apps/vs-code-react/src/app/overview/app.tsx | Stops passing supportsUnitTest into Overview UI. |
| apps/vs-code-react/src/app/overview/test/app.test.tsx | Updates overview tests to remove supportsUnitTest. |
| apps/vs-code-react/src/app/designer/utilities/runInstance.ts | Deletes run instance mock generation utility for unit tests. |
| apps/vs-code-react/src/app/designer/servicesHelper.ts | Updates metadata type name to DesignerPanelMetadata. |
| apps/vs-code-react/src/app/designer/DesignerCommandBar/test/indexV2.test.tsx | Updates command bar tests to remove unit test commands/props. |
| apps/vs-code-react/src/app/designer/appV2.tsx | Removes unit test init/props and run-mock generation in v2 designer host. |
| apps/vs-code-react/src/app/designer/app.tsx | Removes unit test init/props and run-mock generation in v1 designer host. |
| apps/vs-code-react/src/app/designer/test/app.test.tsx | Updates designer app tests to remove unit test state fields. |
| apps/vs-code-react/src/test/stateWrapper.test.tsx | Removes unitTest navigation test case. |
| apps/vs-code-designer/test-setup.ts | Removes unitTest webview key from test setup. |
| apps/vs-code-designer/src/test/e2e/integration/projectOutsideWorkspace.test.ts | Removes unit test-related message assertions. |
| apps/vs-code-designer/src/test/e2e/integration/designerOpens.test.ts | Removes unit test panel title logic/tests; updates webview key list. |
| apps/vs-code-designer/src/main.ts | Removes disposal of unit test controller on deactivate. |
| apps/vs-code-designer/src/extensionVariables.ts | Removes unit test controller/test explorer state from extension globals. |
| apps/vs-code-designer/src/constants.ts | Removes unit test filenames/dirs/settings/events/constants. |
| apps/vs-code-designer/src/app/utils/unitTest/test/unitTest.test.ts | Renames/imports unit test utility module and updates error message expectation. |
| apps/vs-code-designer/src/app/utils/customCodeUtils.ts | Broadens targetFramework type parameter for custom code csproj detection helper. |
| apps/vs-code-designer/src/app/tree/unitTestTree/testWorkspace.ts | Deletes unit test tree workspace node implementation. |
| apps/vs-code-designer/src/app/tree/unitTestTree/testWorkflow.ts | Deletes unit test workflow tree node implementation. |
| apps/vs-code-designer/src/app/tree/unitTestTree/testFile.ts | Deletes unit test file tree node implementation. |
| apps/vs-code-designer/src/app/commands/workflows/unitTest/createUnitTestFromRun.ts | Refactors imports/telemetry/error messaging for unit test creation from run. |
| apps/vs-code-designer/src/app/commands/workflows/unitTest/createUnitTest.ts | Refactors imports/command wiring for unit test creation. |
| apps/vs-code-designer/src/app/commands/workflows/unitTest/codelessUnitTest/openUnitTestResults.ts | Deletes unused unit test results webview implementation. |
| apps/vs-code-designer/src/app/commands/workflows/unitTest/codelessUnitTest/editUnitTest.ts | Deletes unused unit test editor entrypoint. |
| apps/vs-code-designer/src/app/commands/workflows/unitTest/test/createUnitTest.test.ts | Updates unit test command tests for refactored import paths. |
| apps/vs-code-designer/src/app/commands/workflows/openOverview.ts | Refactors monitoring view import path; removes unit test support payload. |
| apps/vs-code-designer/src/app/commands/workflows/openMonitoringView/openMonitoringView.ts | Deletes old monitoring view entrypoint wrapper. |
| apps/vs-code-designer/src/app/commands/workflows/openDesigner/openDesigner.ts | Deletes old designer entrypoint wrapper. |
| apps/vs-code-designer/src/app/commands/workflows/monitoringView/panels/remoteMonitoringPanel.ts | Refactors remote monitoring panel into new class pattern + updated metadata typing. |
| apps/vs-code-designer/src/app/commands/workflows/monitoringView/panels/monitoringPanel.ts | Introduces/renames base monitoring panel class derived from designer panel base. |
| apps/vs-code-designer/src/app/commands/workflows/monitoringView/panels/test/remoteMonitoringPanel.test.ts | Updates tests for renamed/refactored remote monitoring panel class. |
| apps/vs-code-designer/src/app/commands/workflows/monitoringView/openMonitoringView.ts | Adds new monitoring view entrypoint using new panel classes + telemetry. |
| apps/vs-code-designer/src/app/commands/workflows/designer/panels/remoteDesignerPanel.ts | Refactors remote designer panel into new class pattern + updated metadata typing. |
| apps/vs-code-designer/src/app/commands/workflows/designer/panels/test/remoteDesignerPanel.test.ts | Updates tests for renamed/refactored remote designer panel class. |
| apps/vs-code-designer/src/app/commands/workflows/designer/panels/test/designerPanel.test.ts | Updates tests for renamed base designer panel class. |
| apps/vs-code-designer/src/app/commands/workflows/designer/openDesigner.ts | Adds new designer entrypoint that chooses local vs remote panel and handles missing node. |
| apps/vs-code-designer/src/app/commands/workflows/connectionView/panels/test/connectionPanelRace.test.ts | Updates connection panel tests for refactor/renames + updated base class mocking. |
| apps/vs-code-designer/src/app/commands/workflows/connectionView/panels/test/connectionPanel.test.ts | Updates imports for renamed connection panel module. |
| apps/vs-code-designer/src/app/commands/workflows/connectionView/openConnectionView.ts | Adds new connection view entrypoint to construct and create the connection panel. |
| apps/vs-code-designer/src/app/commands/workflows/test/openOverview.test.ts | Updates monitoring view import path and expectations for supportsUnitTest removal. |
| apps/vs-code-designer/src/app/commands/registerCommands.ts | Rewires designer + connection view command entrypoints to new module locations. |
| apps/vs-code-designer/src/app/commands/dataMapper/DataMapperPanel.ts | Removes wrapper sendMsgToWebview and posts messages directly. |
| apps/Standalone/src/designer/state/workflowLoadingSlice.ts | Removes unit test view state and reducer action from standalone loader. |
| apps/Standalone/src/designer/state/workflowLoadingSelectors.ts | Removes useIsUnitTestView selector. |
| apps/Standalone/src/designer/state/historyHelpers.ts | Stops persisting unit test view state in history. |
| apps/Standalone/src/designer/app/SettingsSections/contextSettings.tsx | Removes “Unit Test View” toggle and related behavior. |
| apps/Standalone/src/designer/app/AzureLogicAppsDesigner/laDesignerV2.tsx | Removes isUnitTest option wiring in standalone designer v2 host. |
| apps/Standalone/src/designer/app/AzureLogicAppsDesigner/laDesignerConsumptionV2.tsx | Removes hardcoded isUnitTest={false} prop. |
| apps/Standalone/src/designer/app/AzureLogicAppsDesigner/laDesignerConsumption.tsx | Removes hardcoded isUnitTest={false} prop. |
| apps/Standalone/src/designer/app/AzureLogicAppsDesigner/laDesigner.tsx | Removes isUnitTest option wiring in standalone designer v1 host. |
| apps/Standalone/src/designer/app/AzureLogicAppsDesigner/DesignerCommandBarV2.tsx | Removes unit test save/assertions menu actions and related validation. |
| apps/Standalone/src/designer/app/AzureLogicAppsDesigner/DesignerCommandBar.tsx | Removes unit test save/assertions command bar actions and related validation. |
| .github/workflows/issue-triage-agent.md | Updates docs to remove v2 unit test slice reference. |
| .github/lib-descriptions/vscode-extension.md | Updates library description to remove unit test model mention. |
| .github/lib-descriptions/designer.md | Updates designer library description to remove unit test serialization/slice/panels. |
| .github/lib-descriptions/designer-v2.md | Updates v2 description to remove unit test slice/panel mentions. |
| .github/lib-descriptions/designer-ui.md | Updates designer-ui description to remove unit testing component mention. |
| .github/instructions/logic-apps-shared.instructions.md | Removes unit-test error handling import guidance. |
…codeDesignerRefactor
Contributor
📊 Coverage CheckThe following changed files need attention: ❌
Please add tests for the uncovered files before merging. |
Contributor
Author
Some of the files it's complaining have 0% coverage don't exist anymore... also 75% coverage should not trigger a warning this is excessive. Bot needs to be fixed |
andrew-eldridge
added
risk:medium
github-actions
Bot
added
pr-validated
needs-pr-update
and removed
needs-pr-update
labels
github-actions
Bot
added
needs-pr-update
pr-validated
and removed
pr-validated
needs-pr-update
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
Refactors designer/monitoring view/connection view classes to follow more consistent pattern in preparation for new corresponding V2 designer classes. Addresses some linting errors as well. Low risk due to no significant behavioral changes.
Impact of Change
Test Plan
Contributors
@andrew-eldridge