[Load] Fix Azure/azure-cli-extensions#10020: az load test create: Fix --test-id not required when testId is specified in YAML config file#10021
Draft
Copilot wants to merge 2 commits into
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @copilot, |
…en testId is in YAML config
Copilot
AI
changed the title
[WIP] Fix az load test create to not require test-id from CLI
[Load] Fix Azure/azure-cli-extensions#10020: az load test create: Fix --test-id not required when testId is specified in YAML config file
Jun 22, 2026
Collaborator
|
Load |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
az load test createrejected commands withthe following arguments are required: --test-id/-teven whentestIdwas present in the YAML config passed via--load-test-config-file. The validator ran before the command handler and had no awareness of the config file.Changes
validators.py—validate_test_idnow checksnamespace.load_test_config_filewhentest_idisNone; if the YAML file is present and containstestId, it populatesnamespace.test_idbefore running format validation. CLI-provided--test-idalways takes precedence.constants.py— AddedTEST_ID = "testId"toLoadTestConfigKeys.argtypes.py— Updatedtest_id_no_completerhelp text to reflect optional behavior.help.py— Added example showingaz load test createwithout--test-idwhentestIdis in the config file.HISTORY.rst— Added changelog entry under new version2.1.1.test_load_test_id_from_yaml_unit.py— Unit tests covering: read from YAML, CLI arg precedence, missing key, invalid format, and required-when-absent cases.Example
Given a config file
test.yamlwithtestId: my-test:Related command
az load test createGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (azdevrequired; see.azure-pipelines/templates/azdev_setup.ymlfor the install command untilazdev==0.2.11b1is on PyPI)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.